@@ -509,7 +509,7 @@ public void getIsDeviceAllowedToSendFragmentScreenTraces_8digitSamplingRate_frag
509
509
when (mockConfigResolver .getFragmentSamplingRate ()).thenReturn (0.00000001f );
510
510
511
511
RateLimiter limiter =
512
- new RateLimiter (TWO_TOKENS_PER_MINUTE , 2 , mClock , 1 , 0.000000005f , mockConfigResolver );
512
+ new RateLimiter (TWO_TOKENS_PER_MINUTE , 2 , mClock , 0.99f , 0.000000005f , mockConfigResolver );
513
513
514
514
assertThat (limiter .getIsDeviceAllowedToSendFragmentScreenTraces ()).isTrue ();
515
515
}
@@ -949,8 +949,9 @@ public void testNetworkRequestsAreNotSampledWhenSessionIsVerboseAndSamplingEnabl
949
949
}
950
950
951
951
@ Test
952
- public void isEventSampled_verboseSessionEnabledAndDiceRollFailed_returnsTrue () {
952
+ public void isEventSampled_fragmentWithVerboseSessionEnabled_returnsTrue () {
953
953
makeConfigResolverReturnDefaultValues ();
954
+ when (mockConfigResolver .getTraceSamplingRate ()).thenReturn (1.0f );
954
955
when (mockConfigResolver .getFragmentSamplingRate ()).thenReturn (0.70f );
955
956
956
957
// Passing a value for samplingBucketId which is greater than the sampling rate means that
@@ -970,9 +971,11 @@ public void isEventSampled_verboseSessionEnabledAndDiceRollFailed_returnsTrue()
970
971
PerfMetric .newBuilder ()
971
972
.setTraceMetric (
972
973
TraceMetric .newBuilder ()
974
+ .setName ("_st_TestFragment" )
975
+ .putCustomAttributes (Constants .ACTIVITY_ATTRIBUTE_KEY , "TestActivity" )
973
976
.addAllPerfSessions (Arrays .asList (createVerbosePerfSessions ())))
974
977
.build ();
975
-
978
+ assertThat ( limiter . isFragmentScreenTrace ( trace )). isTrue ();
976
979
assertThat (limiter .isEventSampled (trace )).isTrue ();
977
980
}
978
981
@@ -1031,9 +1034,10 @@ public void testNetworkRequestsAreSampledWhenSessionIsNonVerboseAndSamplingEnabl
1031
1034
}
1032
1035
1033
1036
@ Test
1034
- public void isEventSampled_verboseSessionDisabledAndDiceRollFailed_returnsFalse () {
1037
+ public void isEventSampled_fragmentWithVerboseSessionDisabled_returnsFalse () {
1035
1038
makeConfigResolverReturnDefaultValues ();
1036
1039
when (mockConfigResolver .getFragmentSamplingRate ()).thenReturn (0.70f );
1040
+ when (mockConfigResolver .getTraceSamplingRate ()).thenReturn (1.0f );
1037
1041
1038
1042
// Passing a value for samplingBucketId which is greater than the sampling rate means that
1039
1043
// the sampling dice roll failed causing all the metrics to be dropped
@@ -1052,9 +1056,11 @@ public void isEventSampled_verboseSessionDisabledAndDiceRollFailed_returnsFalse(
1052
1056
PerfMetric .newBuilder ()
1053
1057
.setTraceMetric (
1054
1058
TraceMetric .newBuilder ()
1059
+ .setName ("_st_TestFragment" )
1060
+ .putCustomAttributes (Constants .ACTIVITY_ATTRIBUTE_KEY , "TestActivity" )
1055
1061
.addAllPerfSessions (Arrays .asList (createNonVerbosePerfSessions ())))
1056
1062
.build ();
1057
-
1063
+ assertThat ( limiter . isFragmentScreenTrace ( trace )). isTrue ();
1058
1064
assertThat (limiter .isEventSampled (trace )).isFalse ();
1059
1065
}
1060
1066
@@ -1063,6 +1069,7 @@ public void testGaugesAreNeverSampled() {
1063
1069
makeConfigResolverReturnDefaultValues ();
1064
1070
when (mockConfigResolver .getTraceSamplingRate ()).thenReturn (0.70f );
1065
1071
when (mockConfigResolver .getNetworkRequestSamplingRate ()).thenReturn (0.70f );
1072
+ when (mockConfigResolver .getFragmentSamplingRate ()).thenReturn (0.70f );
1066
1073
1067
1074
// Passing a value for samplingBucketId which is greater than the sampling rate ensures that
1068
1075
// the sampling will be enabled causing all the metrics to be dropped
@@ -1072,7 +1079,7 @@ public void testGaugesAreNeverSampled() {
1072
1079
/* capacity= */ 2 ,
1073
1080
mClock ,
1074
1081
/* samplingBucketId= */ 0.71f ,
1075
- /* fragmentBucketId= */ 1 ,
1082
+ /* fragmentBucketId= */ 0.71f ,
1076
1083
mockConfigResolver );
1077
1084
assertThat (limiter .getIsDeviceAllowedToSendTraces ()).isFalse ();
1078
1085
assertThat (limiter .getIsDeviceAllowedToSendNetworkEvents ()).isFalse ();
0 commit comments