Skip to content

Commit df895e7

Browse files
committed
fix test
1 parent 10ddb84 commit df895e7

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

firebase-perf/src/test/java/com/google/firebase/perf/transport/RateLimiterTest.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ public void getIsDeviceAllowedToSendFragmentScreenTraces_8digitSamplingRate_frag
509509
when(mockConfigResolver.getFragmentSamplingRate()).thenReturn(0.00000001f);
510510

511511
RateLimiter limiter =
512-
new RateLimiter(TWO_TOKENS_PER_MINUTE, 2, mClock, 1, 0.000000005f, mockConfigResolver);
512+
new RateLimiter(TWO_TOKENS_PER_MINUTE, 2, mClock, 0.99f, 0.000000005f, mockConfigResolver);
513513

514514
assertThat(limiter.getIsDeviceAllowedToSendFragmentScreenTraces()).isTrue();
515515
}
@@ -949,8 +949,9 @@ public void testNetworkRequestsAreNotSampledWhenSessionIsVerboseAndSamplingEnabl
949949
}
950950

951951
@Test
952-
public void isEventSampled_verboseSessionEnabledAndDiceRollFailed_returnsTrue() {
952+
public void isEventSampled_fragmentWithVerboseSessionEnabled_returnsTrue() {
953953
makeConfigResolverReturnDefaultValues();
954+
when(mockConfigResolver.getTraceSamplingRate()).thenReturn(1.0f);
954955
when(mockConfigResolver.getFragmentSamplingRate()).thenReturn(0.70f);
955956

956957
// Passing a value for samplingBucketId which is greater than the sampling rate means that
@@ -970,9 +971,11 @@ public void isEventSampled_verboseSessionEnabledAndDiceRollFailed_returnsTrue()
970971
PerfMetric.newBuilder()
971972
.setTraceMetric(
972973
TraceMetric.newBuilder()
974+
.setName("_st_TestFragment")
975+
.putCustomAttributes(Constants.ACTIVITY_ATTRIBUTE_KEY, "TestActivity")
973976
.addAllPerfSessions(Arrays.asList(createVerbosePerfSessions())))
974977
.build();
975-
978+
assertThat(limiter.isFragmentScreenTrace(trace)).isTrue();
976979
assertThat(limiter.isEventSampled(trace)).isTrue();
977980
}
978981

@@ -1031,9 +1034,10 @@ public void testNetworkRequestsAreSampledWhenSessionIsNonVerboseAndSamplingEnabl
10311034
}
10321035

10331036
@Test
1034-
public void isEventSampled_verboseSessionDisabledAndDiceRollFailed_returnsFalse() {
1037+
public void isEventSampled_fragmentWithVerboseSessionDisabled_returnsFalse() {
10351038
makeConfigResolverReturnDefaultValues();
10361039
when(mockConfigResolver.getFragmentSamplingRate()).thenReturn(0.70f);
1040+
when(mockConfigResolver.getTraceSamplingRate()).thenReturn(1.0f);
10371041

10381042
// Passing a value for samplingBucketId which is greater than the sampling rate means that
10391043
// the sampling dice roll failed causing all the metrics to be dropped
@@ -1052,9 +1056,11 @@ public void isEventSampled_verboseSessionDisabledAndDiceRollFailed_returnsFalse(
10521056
PerfMetric.newBuilder()
10531057
.setTraceMetric(
10541058
TraceMetric.newBuilder()
1059+
.setName("_st_TestFragment")
1060+
.putCustomAttributes(Constants.ACTIVITY_ATTRIBUTE_KEY, "TestActivity")
10551061
.addAllPerfSessions(Arrays.asList(createNonVerbosePerfSessions())))
10561062
.build();
1057-
1063+
assertThat(limiter.isFragmentScreenTrace(trace)).isTrue();
10581064
assertThat(limiter.isEventSampled(trace)).isFalse();
10591065
}
10601066

@@ -1063,6 +1069,7 @@ public void testGaugesAreNeverSampled() {
10631069
makeConfigResolverReturnDefaultValues();
10641070
when(mockConfigResolver.getTraceSamplingRate()).thenReturn(0.70f);
10651071
when(mockConfigResolver.getNetworkRequestSamplingRate()).thenReturn(0.70f);
1072+
when(mockConfigResolver.getFragmentSamplingRate()).thenReturn(0.70f);
10661073

10671074
// Passing a value for samplingBucketId which is greater than the sampling rate ensures that
10681075
// the sampling will be enabled causing all the metrics to be dropped
@@ -1072,7 +1079,7 @@ public void testGaugesAreNeverSampled() {
10721079
/* capacity= */ 2,
10731080
mClock,
10741081
/* samplingBucketId= */ 0.71f,
1075-
/* fragmentBucketId= */ 1,
1082+
/* fragmentBucketId= */ 0.71f,
10761083
mockConfigResolver);
10771084
assertThat(limiter.getIsDeviceAllowedToSendTraces()).isFalse();
10781085
assertThat(limiter.getIsDeviceAllowedToSendNetworkEvents()).isFalse();

0 commit comments

Comments
 (0)