Skip to content

Commit e1c3de7

Browse files
committed
address feedback
1 parent 9bc8992 commit e1c3de7

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ private void doStartFeedback(CharSequence infoText, @Nullable Uri screenshotUri)
412412
}
413413

414414
private Task<Void> launchFeedbackActivity(
415-
String releaseName, CharSequence infoText, @Nullable Uri screenshotUri) {
415+
@Nullable String releaseName, CharSequence infoText, @Nullable Uri screenshotUri) {
416416
return lifecycleNotifier.consumeForegroundActivity(
417417
activity -> {
418418
LogWrapper.getInstance().i("Launching feedback activity");

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/ReleaseIdentifier.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,12 @@ class ReleaseIdentifier {
5656
this.testerApiClient = testerApiClient;
5757
}
5858

59-
/** Identify the currently installed release, returning the release name. */
59+
/**
60+
* Identify the currently installed release, returning the release name.
61+
*
62+
* <p>Will return {@code Task} with a {@code null} result in "developer mode" which allows the UI
63+
* to be used, but no actual feedback to be submitted.
64+
*/
6065
Task<String> identifyRelease() {
6166
if (developmentModeEnabled()) {
6267
return Tasks.forResult(null);

firebase-appdistribution/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<string name="app_update_notification_channel_name">App updates</string>
3333
<string name="app_update_notification_channel_description">Shows progress of in-app updates</string>
3434
<string name="feedback_launch_failed">Failed to launch feedback</string>
35-
<string name="feedback_unidentified_release">Release not accessible. Probably not installed via App Distribution</string>
35+
<string name="feedback_unidentified_release">Release not found. This app may not have been installed by App Distribution, or you may no longer have access</string>
3636
<string name="feedback_no_release">Would have sent feedback</string>
3737
<string name="feedback_notification_channel_name">Feedback</string>
3838
<string name="feedback_notification_channel_description">Tap to leave feedback</string>

0 commit comments

Comments
 (0)