Cleanup, unittests for version logic

Author: vkryachko

firebase-installations/customer-lint-checks/customer-lint-checks.gradle

@@ -27,6 +27,7 @@ dependencies {
     testImplementation "com.android.tools.lint:lint:$lintVersion"
     testImplementation "com.android.tools.lint:lint-tests:$lintVersion"
     testImplementation "com.android.tools:testutils:$lintVersion"
+    testImplementation "com.google.truth:truth:$googleTruthVersion"
 }
 
 compileKotlin.kotlinOptions.apiVersion = '1.2'

firebase-installations/customer-lint-checks/src/main/java/com/google/firebase/installations/lint/Checks.kt

@@ -20,7 +20,10 @@ import com.android.tools.lint.detector.api.Issue
 
 class Checks : IssueRegistry() {
     override val issues: List<Issue>
-        get() = listOf(IncompatibleIidVersionDetector.INCOMPATIBLE_IID_VERSION)
+        get() = listOf(
+                IncompatibleIidVersionDetector.INCOMPATIBLE_IID_VERSION,
+                IncompatibleIidVersionDetector.IID_COMPATIBILITY_CHECK_FAILURE
+        )
 
     override val api: Int
         get() = CURRENT_API

firebase-installations/customer-lint-checks/src/main/java/com/google/firebase/installations/lint/IncompatibleIidVersionDetector.kt

@@ -14,7 +14,6 @@
 
 package com.google.firebase.installations.lint
 
-import com.android.builder.model.MavenCoordinates
 import com.android.builder.model.Variant
 import com.android.tools.lint.detector.api.Category
 import com.android.tools.lint.detector.api.Context
@@ -70,7 +69,7 @@ class IncompatibleIidVersionDetector : Detector() {
             for (lib in variant.mainArtifact.dependencies.libraries) {
                 val coordinates = lib.resolvedCoordinates
                 if (coordinates.groupId == "com.google.firebase" && coordinates.artifactId == "firebase-iid") {
-                    if (!isCompatibleVersion(coordinates)) {
+                    if (!isCompatibleVersion(coordinates.version)) {
                         context.report(INCOMPATIBLE_IID_VERSION,
                                 Location.create(context.file),
                                 "Incompatible IID version found in variant ${variant.name}: ${lib.name.removeSuffix("@aar")}.\n" +
@@ -96,8 +95,8 @@ class IncompatibleIidVersionDetector : Detector() {
         return variantsMethod.invoke(model) as List<Variant>
     }
 
-    private fun isCompatibleVersion(coordinates: MavenCoordinates): Boolean {
-        val versionComponents = coordinates.version.split('.', limit = 3).toTypedArray()
+    internal fun isCompatibleVersion(version: String): Boolean {
+        val versionComponents = version.split('.', limit = 3).toTypedArray()
 
         // Incompatible if major version is before v20
         if (20 > versionComponents[0].toInt()) {

firebase-installations/customer-lint-checks/src/test/java/com/google/firebase/installations/lint/VersionTests.kt

@@ -0,0 +1,52 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.firebase.installations.lint
+
+import com.google.common.truth.Truth.assertThat
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.JUnit4
+
+@RunWith(JUnit4::class)
+class VersionTests {
+    companion object Detector {
+        val detector = IncompatibleIidVersionDetector()
+    }
+
+    @Test
+    fun `isCompatibleVersion with 19_0_0 should be false`() {
+        assertThat(detector.isCompatibleVersion("19.0.0")).isFalse()
+    }
+
+    @Test
+    fun `isCompatibleVersion with 20_0_0 should be false`() {
+        assertThat(detector.isCompatibleVersion("20.0.0")).isFalse()
+    }
+
+    @Test
+    fun `isCompatibleVersion with 20_1_0 should be true`() {
+        assertThat(detector.isCompatibleVersion("20.1.0")).isTrue()
+    }
+
+    @Test
+    fun `isCompatibleVersion with 20_1_1 should be true`() {
+        assertThat(detector.isCompatibleVersion("20.1.1")).isTrue()
+    }
+
+    @Test
+    fun `isCompatibleVersion with 21_0_0 should be true`() {
+        assertThat(detector.isCompatibleVersion("21.0.0")).isTrue()
+    }
+}