Skip to content

Commit e6472e8

Browse files
authored
Move the NetworkRequestBuilder package inside metrics to unify the builders. (#2526)
1 parent 948896a commit e6472e8

24 files changed

+27
-47
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/impl/package-info.java

Lines changed: 0 additions & 18 deletions
This file was deleted.

firebase-perf/src/main/java/com/google/firebase/perf/metrics/HttpMetric.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import com.google.firebase.perf.FirebasePerformance.HttpMethod;
2020
import com.google.firebase.perf.FirebasePerformanceAttributable;
2121
import com.google.firebase.perf.config.ConfigResolver;
22-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
2322
import com.google.firebase.perf.logging.AndroidLogger;
2423
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;
2524
import com.google.firebase.perf.transport.TransportManager;

firebase-perf/src/main/java/com/google/firebase/perf/impl/NetworkRequestMetricBuilder.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/metrics/NetworkRequestMetricBuilder.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// Copyright 2020 Google LLC
1+
// Copyright 2021 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
5-
//
65
// You may obtain a copy of the License at
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
88
//
99
// Unless required by applicable law or agreed to in writing, software
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.impl;
15+
package com.google.firebase.perf.metrics;
1616

1717
import static com.google.firebase.perf.network.NetworkRequestMetricBuilderUtil.isAllowedUserAgent;
1818

@@ -25,7 +25,6 @@
2525
import com.google.firebase.perf.internal.SessionAwareObject;
2626
import com.google.firebase.perf.internal.SessionManager;
2727
import com.google.firebase.perf.logging.AndroidLogger;
28-
import com.google.firebase.perf.metrics.HttpMetric;
2928
import com.google.firebase.perf.transport.TransportManager;
3029
import com.google.firebase.perf.util.Constants;
3130
import com.google.firebase.perf.util.Timer;

firebase-perf/src/main/java/com/google/firebase/perf/network/FirebasePerfHttpClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
package com.google.firebase.perf.network;
1616

1717
import androidx.annotation.Keep;
18-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
18+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1919
import com.google.firebase.perf.transport.TransportManager;
2020
import com.google.firebase.perf.util.Timer;
2121
import java.io.IOException;

firebase-perf/src/main/java/com/google/firebase/perf/network/FirebasePerfOkHttpClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
package com.google.firebase.perf.network;
1616

1717
import androidx.annotation.Keep;
18-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
18+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1919
import com.google.firebase.perf.transport.TransportManager;
2020
import com.google.firebase.perf.util.Timer;
2121
import java.io.IOException;

firebase-perf/src/main/java/com/google/firebase/perf/network/FirebasePerfUrlConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
package com.google.firebase.perf.network;
1616

1717
import androidx.annotation.Keep;
18-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
18+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1919
import com.google.firebase.perf.transport.TransportManager;
2020
import com.google.firebase.perf.util.Timer;
2121
import com.google.firebase.perf.util.URLWrapper;

firebase-perf/src/main/java/com/google/firebase/perf/network/InstrHttpInputStream.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package com.google.firebase.perf.network;
1616

17-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
17+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1818
import com.google.firebase.perf.util.Timer;
1919
import java.io.IOException;
2020
import java.io.InputStream;

firebase-perf/src/main/java/com/google/firebase/perf/network/InstrHttpOutputStream.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package com.google.firebase.perf.network;
1616

17-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
17+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1818
import com.google.firebase.perf.util.Timer;
1919
import java.io.IOException;
2020
import java.io.OutputStream;

firebase-perf/src/main/java/com/google/firebase/perf/network/InstrHttpURLConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package com.google.firebase.perf.network;
1616

17-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
17+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1818
import com.google.firebase.perf.util.Timer;
1919
import java.io.IOException;
2020
import java.io.InputStream;

firebase-perf/src/main/java/com/google/firebase/perf/network/InstrHttpsURLConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package com.google.firebase.perf.network;
1616

17-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
17+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1818
import com.google.firebase.perf.util.Timer;
1919
import java.io.IOException;
2020
import java.io.InputStream;

firebase-perf/src/main/java/com/google/firebase/perf/network/InstrURLConnectionBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
package com.google.firebase.perf.network;
1616

1717
import android.os.Build;
18-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
1918
import com.google.firebase.perf.logging.AndroidLogger;
19+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2020
import com.google.firebase.perf.util.Timer;
2121
import java.io.IOException;
2222
import java.io.InputStream;

firebase-perf/src/main/java/com/google/firebase/perf/network/InstrumentApacheHttpResponseHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package com.google.firebase.perf.network;
1616

17-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
17+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1818
import com.google.firebase.perf.util.Timer;
1919
import java.io.IOException;
2020
import org.apache.http.HttpResponse;

firebase-perf/src/main/java/com/google/firebase/perf/network/InstrumentOkHttpEnqueueCallback.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package com.google.firebase.perf.network;
1616

17-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
17+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
1818
import com.google.firebase.perf.transport.TransportManager;
1919
import com.google.firebase.perf.util.Timer;
2020
import java.io.IOException;

firebase-perf/src/main/java/com/google/firebase/perf/network/NetworkRequestMetricBuilderUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
import androidx.annotation.NonNull;
1818
import androidx.annotation.Nullable;
19-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
2019
import com.google.firebase.perf.logging.AndroidLogger;
20+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2121
import java.util.regex.Pattern;
2222
import org.apache.http.Header;
2323
import org.apache.http.HttpMessage;

firebase-perf/src/test/java/com/google/firebase/perf/internal/AppStateMonitorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import com.google.firebase.perf.FirebasePerformanceTestBase;
3636
import com.google.firebase.perf.config.ConfigResolver;
3737
import com.google.firebase.perf.config.DeviceCacheManager;
38-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
38+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
3939
import com.google.firebase.perf.metrics.Trace;
4040
import com.google.firebase.perf.transport.TransportManager;
4141
import com.google.firebase.perf.util.Clock;

firebase-perf/src/test/java/com/google/firebase/perf/impl/NetworkRequestMetricBuilderTest.java renamed to firebase-perf/src/test/java/com/google/firebase/perf/metrics/NetworkRequestMetricBuilderTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// Copyright 2020 Google LLC
1+
// Copyright 2021 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
5-
//
65
// You may obtain a copy of the License at
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
88
//
99
// Unless required by applicable law or agreed to in writing, software
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.impl;
15+
package com.google.firebase.perf.metrics;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static org.mockito.Mockito.mock;
@@ -40,7 +40,7 @@
4040
import org.mockito.Mock;
4141
import org.robolectric.RobolectricTestRunner;
4242

43-
/** Unit tests for {@link com.google.firebase.perf.impl.NetworkRequestMetricBuilder}. */
43+
/** Unit tests for {@link com.google.firebase.perf.metrics.NetworkRequestMetricBuilder}. */
4444
@RunWith(RobolectricTestRunner.class)
4545
public class NetworkRequestMetricBuilderTest extends FirebasePerformanceTestBase {
4646

firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfNetworkValidatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import static org.junit.Assert.assertTrue;
2020

2121
import com.google.firebase.perf.FirebasePerformanceTestBase;
22-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
22+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2323
import com.google.firebase.perf.transport.TransportManager;
2424
import com.google.firebase.perf.v1.NetworkRequestMetric;
2525
import com.google.firebase.perf.v1.NetworkRequestMetric.HttpMethod;

firebase-perf/src/test/java/com/google/firebase/perf/network/FirebasePerfOkHttpClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import static org.mockito.Mockito.verify;
1919

2020
import com.google.firebase.perf.FirebasePerformanceTestBase;
21-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
21+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2222
import com.google.firebase.perf.transport.TransportManager;
2323
import com.google.firebase.perf.v1.ApplicationProcessState;
2424
import com.google.firebase.perf.v1.NetworkRequestMetric;

firebase-perf/src/test/java/com/google/firebase/perf/network/InstrHttpInputStreamTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import static org.mockito.Mockito.when;
2323

2424
import com.google.firebase.perf.FirebasePerformanceTestBase;
25-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
25+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2626
import com.google.firebase.perf.transport.TransportManager;
2727
import com.google.firebase.perf.util.Timer;
2828
import com.google.firebase.perf.v1.ApplicationProcessState;

firebase-perf/src/test/java/com/google/firebase/perf/network/InstrHttpOutputStreamTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import static org.mockito.Mockito.when;
2222

2323
import com.google.firebase.perf.FirebasePerformanceTestBase;
24-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
24+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2525
import com.google.firebase.perf.transport.TransportManager;
2626
import com.google.firebase.perf.util.Timer;
2727
import com.google.firebase.perf.v1.ApplicationProcessState;

firebase-perf/src/test/java/com/google/firebase/perf/network/InstrHttpURLConnectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import static org.mockito.MockitoAnnotations.initMocks;
2525

2626
import com.google.firebase.perf.FirebasePerformanceTestBase;
27-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
27+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2828
import com.google.firebase.perf.transport.TransportManager;
2929
import com.google.firebase.perf.util.Timer;
3030
import com.google.firebase.perf.v1.ApplicationProcessState;

firebase-perf/src/test/java/com/google/firebase/perf/network/InstrHttpsURLConnectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import static org.mockito.MockitoAnnotations.initMocks;
2222

2323
import com.google.firebase.perf.FirebasePerformanceTestBase;
24-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
24+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2525
import com.google.firebase.perf.transport.TransportManager;
2626
import com.google.firebase.perf.util.Timer;
2727
import com.google.firebase.perf.v1.ApplicationProcessState;

firebase-perf/src/test/java/com/google/firebase/perf/network/InstrURLConnectionBaseTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import static org.mockito.MockitoAnnotations.initMocks;
2424

2525
import com.google.firebase.perf.FirebasePerformanceTestBase;
26-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
26+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2727
import com.google.firebase.perf.transport.TransportManager;
2828
import com.google.firebase.perf.util.Timer;
2929
import com.google.firebase.perf.v1.ApplicationProcessState;

firebase-perf/src/test/java/com/google/firebase/perf/network/InstrumentApacheHttpResponseHandlerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import static org.mockito.Mockito.when;
2222

2323
import com.google.firebase.perf.FirebasePerformanceTestBase;
24-
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
24+
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
2525
import com.google.firebase.perf.transport.TransportManager;
2626
import com.google.firebase.perf.util.Timer;
2727
import com.google.firebase.perf.v1.ApplicationProcessState;

0 commit comments

Comments
 (0)