Skip to content

Commit ebab909

Browse files
authored
Updating grpc version to 1.52.1 (#4588)
* Updating grpc version to 1.52.1. See more context here: b/265603879
1 parent 18ebb43 commit ebab909

File tree

6 files changed

+15
-8
lines changed

6 files changed

+15
-8
lines changed

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ ext {
5454
robolectricVersion = libs.versions.robolectric.get()
5555
protocVersion = libs.versions.protoc.get()
5656
javaliteVersion = libs.versions.javalite.get()
57+
protobufJavaUtilVersion = libs.versions.protobufjavautil.get()
5758
}
5859

5960
apply plugin: com.google.firebase.gradle.plugins.publish.PublishingPlugin

encoders/firebase-encoders-proto/firebase-encoders-proto.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ dependencies {
4444

4545
testImplementation 'com.google.guava:guava:31.0-jre'
4646
testImplementation 'junit:junit:4.13.1'
47-
testImplementation 'com.google.protobuf:protobuf-java-util:3.11.0'
47+
testImplementation "com.google.protobuf:protobuf-java-util:$protobufJavaUtilVersion"
4848
testImplementation 'com.google.truth.extensions:truth-proto-extension:1.0'
4949
testImplementation "com.google.truth:truth:$googleTruthVersion"
5050

firebase-ml-modeldownloader/firebase-ml-modeldownloader.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ dependencies {
9494
testImplementation "com.google.truth:truth:$googleTruthVersion"
9595
testImplementation "org.robolectric:robolectric:$robolectricVersion"
9696
testImplementation 'com.google.truth.extensions:truth-proto-extension:1.0'
97-
testImplementation 'com.google.protobuf:protobuf-java-util:3.11.0'
97+
testImplementation "com.google.protobuf:protobuf-java-util:$protobufJavaUtilVersion"
9898
testImplementation 'junit:junit:4.13-beta-2'
9999

100100
//Android compatible version of Apache httpclient.

firebase-ml-modeldownloader/src/androidTest/java/com/google/firebase/ml/modeldownloader/TestGetModelLocal.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,11 @@ public void localModel_successTestPath()
159159
assertTrue(listModelTask.contains(modelUpdatedTask.getResult()));
160160

161161
// delete the old model
162-
FirebaseModelDownloader.getInstance().deleteDownloadedModel(MODEL_NAME_LOCAL);
162+
Task deleteDownloadedModelTask =
163+
FirebaseModelDownloader.getInstance().deleteDownloadedModel(MODEL_NAME_LOCAL);
164+
Tasks.await(deleteDownloadedModelTask);
163165
listModelTask = getDownloadedModelList();
164-
assertEquals(listModelTask.size(), 1);
166+
assertEquals(1, listModelTask.size());
165167

166168
// verify model file was also deleted
167169
assertNull(modelTask.getResult().getFile());

gradle/libs.versions.toml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
[versions]
2+
# javalite, protoc and protobufjavautil versions should be in sync while updating and
3+
# it needs to match the protobuf version which grpc has transitive dependency on.
24
android-lint = "30.3.1"
35
autovalue = "1.10.1"
46
coroutines = "1.6.4"
57
dagger = "2.43.2"
6-
grpc = "1.50.2"
7-
javalite = "3.17.3"
8+
grpc = "1.52.1"
9+
javalite = "3.21.11"
810
kotlin = "1.7.10"
9-
protoc = "3.17.3"
11+
protoc = "3.21.11"
1012
robolectric = "4.9"
1113
truth = "1.1.2"
14+
protobufjavautil = "3.21.11"
1215

1316
[libraries]
1417
android-lint = { module = "com.android.tools.lint:lint", version.ref = "android-lint"}
@@ -45,3 +48,4 @@ mockito-core = { module = "org.mockito:mockito-core", version = "2.28.2"}
4548
mockito-dexmaker = { module = "com.linkedin.dexmaker:dexmaker-mockito", version = "2.28.3"}
4649
robolectric = {module = "org.robolectric:robolectric", version.ref = "robolectric" }
4750
truth = { module = "com.google.truth:truth", version.ref = "truth"}
51+
protobuf-java-util = { module = "com.google.protobuf:protobuf-java-util", version.ref = "protobufjavautil" }

transport/transport-backend-cct/transport-backend-cct.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ dependencies {
6363
annotationProcessor "com.google.auto.value:auto-value:1.6.5"
6464
annotationProcessor project(':encoders:firebase-encoders-processor')
6565

66-
testImplementation 'com.google.protobuf:protobuf-java-util:3.11.0'
66+
testImplementation "com.google.protobuf:protobuf-java-util:$protobufJavaUtilVersion"
6767
testImplementation 'androidx.test:core:1.2.0'
6868
testImplementation "com.google.truth:truth:$googleTruthVersion"
6969
testImplementation 'com.google.truth.extensions:truth-proto-extension:1.0'

0 commit comments

Comments
 (0)