Implementation with naive settings API

Author: wu-hui

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestoreSettings.java

@@ -38,13 +38,16 @@ public static final class Builder {
     private String host;
     private boolean sslEnabled;
     private boolean persistenceEnabled;
+
+    private boolean memoryLruGcEnabled;
     private long cacheSizeBytes;
 
     /** Constructs a new {@code FirebaseFirestoreSettings} Builder object. */
     public Builder() {
       host = DEFAULT_HOST;
       sslEnabled = true;
       persistenceEnabled = true;
+      memoryLruGcEnabled = false;
       cacheSizeBytes = DEFAULT_CACHE_SIZE_BYTES;
     }
 
@@ -58,6 +61,7 @@ public Builder(@NonNull FirebaseFirestoreSettings settings) {
       sslEnabled = settings.sslEnabled;
       persistenceEnabled = settings.persistenceEnabled;
       cacheSizeBytes = settings.cacheSizeBytes;
+      memoryLruGcEnabled = settings.memoryLruGcEnabled;
     }
 
     /**
@@ -95,6 +99,12 @@ public Builder setPersistenceEnabled(boolean value) {
       return this;
     }
 
+    @NonNull
+    public Builder setMemoryLruGcEnabled(boolean value) {
+      this.memoryLruGcEnabled = value;
+      return this;
+    }
+
     /**
      * Sets an approximate cache size threshold for the on-disk data. If the cache grows beyond this
      * size, Cloud Firestore will start removing data that hasn't been recently used. The size is
@@ -150,6 +160,7 @@ public FirebaseFirestoreSettings build() {
   private final String host;
   private final boolean sslEnabled;
   private final boolean persistenceEnabled;
+  private final boolean memoryLruGcEnabled;
   private final long cacheSizeBytes;
 
   /** Constructs a {@code FirebaseFirestoreSettings} object based on the values in the Builder. */
@@ -158,6 +169,7 @@ private FirebaseFirestoreSettings(Builder builder) {
     sslEnabled = builder.sslEnabled;
     persistenceEnabled = builder.persistenceEnabled;
     cacheSizeBytes = builder.cacheSizeBytes;
+    memoryLruGcEnabled = builder.memoryLruGcEnabled;
   }
 
   @Override
@@ -216,6 +228,10 @@ public boolean isPersistenceEnabled() {
     return persistenceEnabled;
   }
 
+  public boolean isMemoryLruGcEnabled() {
+    return memoryLruGcEnabled;
+  }
+
   /**
    * Returns the threshold for the cache size above which the SDK will attempt to collect the least
    * recently used documents.

firebase-firestore/src/main/java/com/google/firebase/firestore/core/MemoryComponentProvider.java

@@ -17,7 +17,9 @@
 import androidx.annotation.Nullable;
 import com.google.firebase.database.collection.ImmutableSortedSet;
 import com.google.firebase.firestore.local.IndexBackfiller;
+import com.google.firebase.firestore.local.LocalSerializer;
 import com.google.firebase.firestore.local.LocalStore;
+import com.google.firebase.firestore.local.LruGarbageCollector;
 import com.google.firebase.firestore.local.MemoryPersistence;
 import com.google.firebase.firestore.local.Persistence;
 import com.google.firebase.firestore.local.QueryEngine;
@@ -26,6 +28,7 @@
 import com.google.firebase.firestore.model.mutation.MutationBatchResult;
 import com.google.firebase.firestore.remote.AndroidConnectivityMonitor;
 import com.google.firebase.firestore.remote.RemoteEvent;
+import com.google.firebase.firestore.remote.RemoteSerializer;
 import com.google.firebase.firestore.remote.RemoteStore;
 import io.grpc.Status;
 
@@ -64,6 +67,15 @@ protected AndroidConnectivityMonitor createConnectivityMonitor(Configuration con
 
   @Override
   protected Persistence createPersistence(Configuration configuration) {
+    if(configuration.getSettings().isMemoryLruGcEnabled()) {
+      LocalSerializer serializer =
+        new LocalSerializer(new RemoteSerializer(configuration.getDatabaseInfo().getDatabaseId()));
+      LruGarbageCollector.Params params =
+        LruGarbageCollector.Params.WithCacheSizeBytes(
+          configuration.getSettings().getCacheSizeBytes());
+      return MemoryPersistence.createLruGcMemoryPersistence(params, serializer);
+    }
+
     return MemoryPersistence.createEagerGcMemoryPersistence();
   }