Fail tasks returned from firebase-app-distribution-stub (#3295)

* Fail tasks returned from firebase-app-distribution-stub

* Fix package names

* Update firebase-app-distribution-stub api.txt

* Fix ktx package directory structure

Author: lfkellogg

firebase-app-distribution-stub/api.txt

@@ -15,7 +15,6 @@ package com.google.firebase.appdistribution {
   }
 
   public class FirebaseAppDistribution {
-    ctor public FirebaseAppDistribution();
     method @NonNull public com.google.android.gms.tasks.Task<com.google.firebase.appdistribution.AppDistributionRelease> checkForNewRelease();
     method @NonNull public static com.google.firebase.appdistribution.FirebaseAppDistribution getInstance();
     method public boolean isTesterSignedIn();
@@ -26,7 +25,6 @@ package com.google.firebase.appdistribution {
   }
 
   public class FirebaseAppDistributionException extends com.google.firebase.FirebaseException {
-    ctor public FirebaseAppDistributionException();
     method @NonNull public com.google.firebase.appdistribution.FirebaseAppDistributionException.Status getErrorCode();
     method @Nullable public com.google.firebase.appdistribution.AppDistributionRelease getRelease();
   }

firebase-app-distribution-stub/firebase-app-distribution-stub.gradle

@@ -45,6 +45,7 @@ dependencies {
 
     testImplementation 'junit:junit:4.13.2'
     testImplementation "com.google.truth:truth:$googleTruthVersion"
+    testImplementation "org.robolectric:robolectric:$robolectricVersion"
 
     compileOnly 'com.google.auto.value:auto-value-annotations:1.6.5'
     annotationProcessor 'com.google.auto.value:auto-value:1.6.5'

firebase-app-distribution-stub/ktx/api.txt

@@ -1,5 +1,5 @@
 // Signature format: 2.0
-package com.google.firebase.app.distribution.ktx {
+package com.google.firebase.appdistribution.ktx {
 
   public final class FirebaseAppDistributionKt {
     ctor public FirebaseAppDistributionKt();

firebase-app-distribution-stub/ktx/src/androidTest/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-  package="com.google.firebase.app.distribution.ktx">
+  package="com.google.firebase.appdistribution.ktx">
   <!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
   <!--<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="23" />-->
   <uses-permission android:name="android.permission.INTERNET"/>
@@ -9,5 +9,5 @@
 
   <instrumentation
     android:name="androidx.test.runner.AndroidJUnitRunner"
-    android:targetPackage="3com.google.firebase.app.distribution.ktx" />
+    android:targetPackage="3com.google.firebase.appdistribution.ktx" />
 </manifest>

firebase-app-distribution-stub/ktx/src/androidTest/kotlin/com/google/firebase/app/distribution/ktx/FirebaseAppDistributionTests.kt renamed to firebase-app-distribution-stub/ktx/src/androidTest/kotlin/com/google/firebase/appdistribution/ktx/FirebaseAppDistributionTests.kt

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.firebase.app.distribution.ktx
+package com.google.firebase.appdistribution.ktx
 
 import androidx.test.internal.runner.junit4.AndroidJUnit4ClassRunner
 import com.google.common.truth.Truth

firebase-app-distribution-stub/ktx/src/main/AndroidManifest.xml

@@ -13,7 +13,7 @@
 <!-- limitations under the License. -->
 
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.google.firebase.app.distribution.ktx">
+    package="com.google.firebase.appdistribution.ktx">
     <uses-sdk android:minSdkVersion="16"/>
 
     <application>

firebase-app-distribution-stub/ktx/src/main/kotlin/com/google/firebase/app/distribution/ktx/FirebaseAppDistribution.kt renamed to firebase-app-distribution-stub/ktx/src/main/kotlin/com/google/firebase/appdistribution/ktx/FirebaseAppDistribution.kt

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.firebase.app.distribution.ktx
+package com.google.firebase.appdistribution.ktx
 
 import com.google.firebase.appdistribution.FirebaseAppDistribution
 import com.google.firebase.ktx.Firebase

firebase-app-distribution-stub/src/main/AndroidManifest.xml

@@ -14,7 +14,7 @@
 <!-- limitations under the License. -->
 
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.google.firebase.app.distribution">
+    package="com.google.firebase.appdistribution">
 
     <application>
     </application>

firebase-app-distribution-stub/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java

@@ -17,71 +17,92 @@
 import android.app.Activity;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
+import com.google.android.gms.tasks.OnCanceledListener;
+import com.google.android.gms.tasks.OnCompleteListener;
 import com.google.android.gms.tasks.OnFailureListener;
 import com.google.android.gms.tasks.OnSuccessListener;
 import com.google.android.gms.tasks.Task;
 import com.google.android.gms.tasks.Tasks;
+import com.google.firebase.appdistribution.FirebaseAppDistributionException.Status;
 import java.util.concurrent.Executor;
 
+/** Stubbed version of the Firebase App Distribution API */
 public class FirebaseAppDistribution {
 
+  FirebaseAppDistribution() {}
+
   /** @return a FirebaseAppDistribution instance */
   @NonNull
   public static FirebaseAppDistribution getInstance() {
     return new FirebaseAppDistribution();
   }
 
   /**
-   * Updates the app to the newest release, if one is available. Returns the release information or
-   * null if no update is found. Performs the following actions: 1. If tester is not signed in,
-   * presents the tester with a Google sign in UI 2. Checks if a newer release is available. If so,
-   * presents the tester with a confirmation dialog to begin the download. 3. For APKs, downloads
-   * the binary and starts an installation intent. 4. For AABs, directs the tester to the Play app
-   * to complete the download and installation.
+   * Stubbed version of {@code updateIfNewReleaseAvailable()}.
+   *
+   * @return an {@link UpdateTask} that will fail with a {@link FirebaseAppDistributionException}
+   *     with status {@link Status#APP_RUNNING_IN_PRODUCTION}.
    */
   @NonNull
   public UpdateTask updateIfNewReleaseAvailable() {
-    return new CompletedUpdateTask();
+    return new AppInProductionUpdateTask();
   }
 
-  /** Signs in the App Distribution tester. Presents the tester with a Google sign in UI */
+  /**
+   * Stubbed version of {@code signInTester()}.
+   *
+   * @return a {@link Task} that will fail with a {@link FirebaseAppDistributionException} with
+   *     status {@link Status#APP_RUNNING_IN_PRODUCTION}.
+   */
   @NonNull
   public Task<Void> signInTester() {
-    return Tasks.forResult(null);
+    return getAppInProductionTask();
   }
 
   /**
-   * Returns an AppDistributionRelease if one is available for the current signed in tester. If no
-   * update is found, returns null. If tester is not signed in, presents the tester with a Google
-   * sign in UI
+   * Stubbed version of {@code checkForNewRelease()}.
+   *
+   * @return a {@link Task} that will fail with a {@link FirebaseAppDistributionException} with
+   *     status {@link Status#APP_RUNNING_IN_PRODUCTION}.
    */
   @NonNull
   public synchronized Task<AppDistributionRelease> checkForNewRelease() {
-    return Tasks.forResult(null);
+    return getAppInProductionTask();
   }
 
   /**
-   * Updates app to the newest release. If the newest release is an APK, downloads the binary and
-   * starts an installation If the newest release is an AAB, directs the tester to the Play app to
-   * complete the download and installation.
+   * Stubbed version of {@code updateApp()}.
    *
-   * <p>cancels task with FirebaseAppDistributionException with UPDATE_NOT_AVAILABLE exception if no
-   * new release is cached from checkForNewRelease
+   * @return an {@link UpdateTask} that will fail with a {@link FirebaseAppDistributionException}
+   *     with status {@link Status#APP_RUNNING_IN_PRODUCTION}.
    */
   @NonNull
   public UpdateTask updateApp() {
-    return new CompletedUpdateTask();
+    return new AppInProductionUpdateTask();
   }
 
-  /** Returns true if the App Distribution tester is signed in */
+  /**
+   * Stubbed version of {@code isTesterSignedIn()}.
+   *
+   * @return false
+   */
   public boolean isTesterSignedIn() {
     return false;
   }
 
-  /** Signs out the App Distribution tester */
+  /** Stubbed version of {@code signOutTester()}. */
   public void signOutTester() {}
 
-  private static class CompletedUpdateTask extends UpdateTask {
+  private static <TResult> Task<TResult> getAppInProductionTask() {
+    return Tasks.forException(
+        new FirebaseAppDistributionException(
+            "App is running in production. App Distribution is disabled.",
+            Status.APP_RUNNING_IN_PRODUCTION));
+  }
+
+  private static class AppInProductionUpdateTask extends UpdateTask {
+    private final Task<Void> task = getAppInProductionTask();
+
     @NonNull
     @Override
     public UpdateTask addOnProgressListener(@NonNull OnProgressListener listener) {
@@ -97,76 +118,122 @@ public UpdateTask addOnProgressListener(
 
     @Override
     public boolean isComplete() {
-      return true;
+      return task.isComplete();
     }
 
     @Override
     public boolean isSuccessful() {
-      return true;
+      return task.isSuccessful();
     }
 
     @Override
     public boolean isCanceled() {
-      return false;
+      return task.isCanceled();
     }
 
     @Nullable
     @Override
     public Void getResult() {
-      return null;
+      return task.getResult();
     }
 
     @Nullable
     @Override
     public <X extends Throwable> Void getResult(@NonNull Class<X> aClass) throws X {
-      return null;
+      return task.getResult(aClass);
     }
 
     @Nullable
     @Override
     public Exception getException() {
-      return null;
+      return task.getException();
     }
 
     @NonNull
     @Override
     public Task<Void> addOnSuccessListener(
         @NonNull OnSuccessListener<? super Void> onSuccessListener) {
+      task.addOnSuccessListener(onSuccessListener);
       return this;
     }
 
     @NonNull
     @Override
     public Task<Void> addOnSuccessListener(
         @NonNull Executor executor, @NonNull OnSuccessListener<? super Void> onSuccessListener) {
+      task.addOnSuccessListener(executor, onSuccessListener);
       return this;
     }
 
     @NonNull
     @Override
     public Task<Void> addOnSuccessListener(
         @NonNull Activity activity, @NonNull OnSuccessListener<? super Void> onSuccessListener) {
+      task.addOnSuccessListener(activity, onSuccessListener);
       return this;
     }
 
     @NonNull
     @Override
     public Task<Void> addOnFailureListener(@NonNull OnFailureListener onFailureListener) {
+      task.addOnFailureListener(onFailureListener);
       return this;
     }
 
     @NonNull
     @Override
     public Task<Void> addOnFailureListener(
         @NonNull Executor executor, @NonNull OnFailureListener onFailureListener) {
+      task.addOnFailureListener(executor, onFailureListener);
       return this;
     }
 
     @NonNull
     @Override
     public Task<Void> addOnFailureListener(
         @NonNull Activity activity, @NonNull OnFailureListener onFailureListener) {
+      task.addOnFailureListener(activity, onFailureListener);
       return this;
     }
+
+    @NonNull
+    @Override
+    public Task<Void> addOnCompleteListener(@NonNull OnCompleteListener<Void> onCompleteListener) {
+      return task.addOnCompleteListener(onCompleteListener);
+    }
+
+    @NonNull
+    @Override
+    public Task<Void> addOnCompleteListener(
+        @NonNull Executor executor, @NonNull OnCompleteListener<Void> onCompleteListener) {
+      return task.addOnCompleteListener(executor, onCompleteListener);
+    }
+
+    @NonNull
+    @Override
+    public Task<Void> addOnCompleteListener(
+        @NonNull Activity activity, @NonNull OnCompleteListener<Void> onCompleteListener) {
+      return task.addOnCompleteListener(activity, onCompleteListener);
+    }
+
+    @NonNull
+    @Override
+    public Task<Void> addOnCanceledListener(@NonNull OnCanceledListener onCanceledListener) {
+      return task.addOnCanceledListener(onCanceledListener);
+    }
+
+    @NonNull
+    @Override
+    public Task<Void> addOnCanceledListener(
+        @NonNull Executor executor, @NonNull OnCanceledListener onCanceledListener) {
+      return task.addOnCanceledListener(executor, onCanceledListener);
+    }
+
+    @NonNull
+    @Override
+    public Task<Void> addOnCanceledListener(
+        @NonNull Activity activity, @NonNull OnCanceledListener onCanceledListener) {
+      return task.addOnCanceledListener(activity, onCanceledListener);
+    }
   }
 }

firebase-app-distribution-stub/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistributionException.java

@@ -59,14 +59,23 @@ public enum Status {
     RELEASE_URL_EXPIRED,
   }
 
+  @NonNull private final Status status;
+  @Nullable private final AppDistributionRelease release;
+
+  FirebaseAppDistributionException(@NonNull String message, @NonNull Status status) {
+    super(message);
+    this.status = status;
+    this.release = null;
+  }
+
   /** Get cached release when error was thrown */
   @Nullable
   public AppDistributionRelease getRelease() {
-    return null;
+    return release;
   }
 
   @NonNull
   public Status getErrorCode() {
-    return Status.UNKNOWN;
+    return status;
   }
 }