Skip to content

Commit fd48900

Browse files
committed
Clean up and re-enable OR query integration tests.
1 parent c5cd536 commit fd48900

File tree

1 file changed

+0
-38
lines changed
  • firebase-firestore/src/androidTest/java/com/google/firebase/firestore

1 file changed

+0
-38
lines changed

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1432,31 +1432,6 @@ public void testOrQueriesWithIn() {
14321432
"doc6");
14331433
}
14341434

1435-
@Test
1436-
public void testOrQueriesWithNotIn() {
1437-
assumeTrue(
1438-
"Skip this test if running against production because it results in a "
1439-
+ "'missing index' error. The Firestore Emulator, however, does serve these "
1440-
+ " queries",
1441-
isRunningAgainstEmulator());
1442-
Map<String, Map<String, Object>> testDocs =
1443-
map(
1444-
"doc1", map("a", 1, "b", 0),
1445-
"doc2", map("b", 1),
1446-
"doc3", map("a", 3, "b", 2),
1447-
"doc4", map("a", 1, "b", 3),
1448-
"doc5", map("a", 1),
1449-
"doc6", map("a", 2));
1450-
CollectionReference collection = testCollectionWithDocs(testDocs);
1451-
1452-
// a==2 || b not-in [2,3]
1453-
// Has implicit orderBy b.
1454-
checkOnlineAndOfflineResultsMatch(
1455-
collection.where(Filter.or(Filter.equalTo("a", 2), Filter.notInArray("b", asList(2, 3)))),
1456-
"doc1",
1457-
"doc2");
1458-
}
1459-
14601435
@Test
14611436
public void testOrQueriesWithArrayMembership() {
14621437
Map<String, Map<String, Object>> testDocs =
@@ -1487,10 +1462,6 @@ public void testOrQueriesWithArrayMembership() {
14871462

14881463
@Test
14891464
public void testMultipleInOps() {
1490-
// TODO(orquery): Enable this test against production when possible.
1491-
assumeTrue(
1492-
"Skip this test if running against production because it's not yet supported.",
1493-
isRunningAgainstEmulator());
14941465
Map<String, Map<String, Object>> testDocs =
14951466
map(
14961467
"doc1", map("a", 1, "b", 0),
@@ -1517,10 +1488,6 @@ public void testMultipleInOps() {
15171488

15181489
@Test
15191490
public void testUsingInWithArrayContainsAny() {
1520-
// TODO(orquery): Enable this test against production when possible.
1521-
assumeTrue(
1522-
"Skip this test if running against production because it's not yet supported.",
1523-
isRunningAgainstEmulator());
15241491
Map<String, Map<String, Object>> testDocs =
15251492
map(
15261493
"doc1", map("a", 1, "b", asList(0)),
@@ -1584,11 +1551,6 @@ public void testUsingInWithArrayContains() {
15841551

15851552
@Test
15861553
public void testOrderByEquality() {
1587-
// TODO(orquery): Enable this test against production when possible.
1588-
assumeTrue(
1589-
"Skip this test if running against production because order-by-equality is "
1590-
+ "not supported yet.",
1591-
isRunningAgainstEmulator());
15921554
Map<String, Map<String, Object>> testDocs =
15931555
map(
15941556
"doc1", map("a", 1, "b", asList(0)),

0 commit comments

Comments
 (0)