Skip to content

Always send the user agent regardless of the heartbeat value #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2020
Merged

Always send the user agent regardless of the heartbeat value #2012

merged 1 commit into from
Sep 29, 2020

Conversation

var-const
Copy link
Contributor

@var-const var-const requested a review from wilhuff September 29, 2020 05:28
@googlebot googlebot added the cla: yes Override cla label Sep 29, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (22d1615) Head (c9e11401) Diff
    aar ? 35.4 kB ? (?)
    apk (aggressive) ? 74.6 kB ? (?)
    apk (release) ? 627 kB ? (?)

  • firebase-components

    Type Base (22d1615) Head (c9e11401) Diff
    aar ? 34.5 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 25.2 kB ? (?)

  • firebase-database-collection

    Type Base (22d1615) Head (c9e11401) Diff
    aar ? 34.2 kB ? (?)
    apk (aggressive) ? 268 kB ? (?)
    apk (release) ? 901 kB ? (?)

  • firebase-firestore

    Type Base (22d1615) Head (c9e11401) Diff
    aar ? 999 kB ? (?)
    apk (aggressive) ? 411 kB ? (?)
    apk (release) ? 3.13 MB ? (?)

  • protolite-well-known-types

    Type Base (22d1615) Head (c9e11401) Diff
    aar ? 998 kB ? (?)
    apk (aggressive) ? 132 kB ? (?)
    apk (release) ? 659 kB ? (?)

Test Logs

Notes

Head commit (c9e11401) is created by Prow via merging commits: 22d1615 3c2f680.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from ? (22d1615) to 46.85% (c9e11401) by ?.

    Click to show coverage changes in 264 files.
    Filename Base (22d1615) Head (c9e11401) Diff
    AbstractStream.java ? 36.90% ?
    ActivityScope.java ? 0.00% ?
    AndroidConnectivityMonitor.java ? 40.00% ?
    ApiUtil.java ? 12.50% ?
    ArrayContainsAnyFilter.java ? 100.00% ?
    ArrayContainsFilter.java ? 100.00% ?
    ArrayTransformOperation.java ? 86.49% ?
    ArrayValue.java ? 49.06% ?
    ArrayValueOrBuilder.java ? 0.00% ?
    Assert.java ? 57.14% ?
    AsyncEventListener.java ? 0.00% ?
    AsyncQueue.java ? 76.88% ?
    BackgroundQueue.java ? 100.00% ?
    BasePath.java ? 98.08% ?
    BatchGetDocumentsRequest.java ? 0.00% ?
    BatchGetDocumentsRequestOrBuilder.java ? 0.00% ?
    BatchGetDocumentsResponse.java ? 0.00% ?
    BatchGetDocumentsResponseOrBuilder.java ? 0.00% ?
    BeginTransactionRequest.java ? 0.00% ?
    BeginTransactionRequestOrBuilder.java ? 0.00% ?
    BeginTransactionResponse.java ? 0.00% ?
    BeginTransactionResponseOrBuilder.java ? 0.00% ?
    Blob.java ? 76.92% ?
    Bound.java ? 47.83% ?
    CollectionReference.java ? 13.64% ?
    CommitRequest.java ? 0.00% ?
    CommitRequestOrBuilder.java ? 0.00% ?
    CommitResponse.java ? 0.00% ?
    CommitResponseOrBuilder.java ? 0.00% ?
    CommonProto.java ? 0.00% ?
    ComponentProvider.java ? 100.00% ?
    ConnectivityMonitor.java ? 0.00% ?
    Consumer.java ? 0.00% ?
    CreateDocumentRequest.java ? 0.00% ?
    CreateDocumentRequestOrBuilder.java ? 0.00% ?
    CredentialsProvider.java ? 100.00% ?
    Cursor.java ? 35.59% ?
    CursorOrBuilder.java ? 0.00% ?
    CustomClassMapper.java ? 84.37% ?
    DatabaseId.java ? 69.23% ?
    DatabaseInfo.java ? 90.91% ?
    Datastore.java ? 33.78% ?
    DeleteDocumentRequest.java ? 0.00% ?
    DeleteDocumentRequestOrBuilder.java ? 0.00% ?
    DeleteMutation.java ? 84.21% ?
    Document.java ? 30.90% ?
    DocumentChange.java ? 34.27% ?
    DocumentChangeOrBuilder.java ? 0.00% ?
    DocumentCollections.java ? 83.33% ?
    DocumentDelete.java ? 34.11% ?
    DocumentDeleteOrBuilder.java ? 0.00% ?
    DocumentId.java ? 0.00% ?
    DocumentKey.java ? 96.88% ?
    DocumentMask.java ? 41.11% ?
    DocumentMaskOrBuilder.java ? 0.00% ?
    DocumentOrBuilder.java ? 0.00% ?
    DocumentProto.java ? 0.00% ?
    DocumentReference.java ? 13.14% ?
    DocumentRemove.java ? 28.68% ?
    DocumentRemoveOrBuilder.java ? 0.00% ?
    DocumentSet.java ? 83.56% ?
    DocumentSnapshot.java ? 36.00% ?
    DocumentTransform.java ? 29.95% ?
    DocumentTransformOrBuilder.java ? 0.00% ?
    DocumentViewChange.java ? 90.48% ?
    DocumentViewChangeSet.java ? 87.88% ?
    EmptyCredentialsProvider.java ? 37.50% ?
    EncodedPath.java ? 93.22% ?
    EventListener.java ? 0.00% ?
    EventManager.java ? 96.15% ?
    Exclude.java ? 0.00% ?
    Executors.java ? 100.00% ?
    ExistenceFilter.java ? 0.00% ?
    ExistenceFilterOrBuilder.java ? 0.00% ?
    ExponentialBackoff.java ? 30.43% ?
    FieldFilter.java ? 88.33% ?
    FieldMask.java ? 55.56% ?
    FieldPath.java ? 89.66% ?
    FieldTransform.java ? 64.71% ?
    FieldValue.java ? 82.14% ?
    FileUtil.java ? 0.00% ?
    Filter.java ? 100.00% ?
    FirebaseAuthCredentialsProvider.java ? 0.00% ?
    FirebaseClientGrpcMetadataProvider.java ? 44.00% ?
    FirebaseFirestore.java ? 44.60% ?
    FirebaseFirestoreException.java ? 83.72% ?
    FirebaseFirestoreSettings.java ? 67.24% ?
    FirestoreCallCredentials.java ? 19.23% ?
    FirestoreChannel.java ? 16.07% ?
    FirestoreClient.java ? 33.67% ?
    FirestoreGrpc.java ? 8.73% ?
    FirestoreMultiDbComponent.java ? 66.67% ?
    FirestoreProto.java ? 0.00% ?
    FirestoreRegistrar.java ? 100.00% ?
    Function.java ? 0.00% ?
    GarbageCollectionScheduler.java ? 0.00% ?
    GeoPoint.java ? 91.67% ?
    GetDocumentRequest.java ? 0.00% ?
    GetDocumentRequestOrBuilder.java ? 0.00% ?
    GrpcCallProvider.java ? 68.18% ?
    GrpcMetadataProvider.java ? 0.00% ?
    IgnoreExtraProperties.java ? 0.00% ?
    InFilter.java ? 100.00% ?
    IncomingStreamObserver.java ? 0.00% ?
    IndexCursor.java ? 0.00% ?
    IndexFreeQueryEngine.java ? 95.74% ?
    IndexManager.java ? 0.00% ?
    IndexNumberDecoder.java ? 0.00% ?
    IndexNumberEncoder.java ? 0.00% ?
    IndexRange.java ? 88.89% ?
    IndexedQueryEngine.java ? 62.69% ?
    KeyFieldFilter.java ? 66.67% ?
    KeyFieldInFilter.java ? 0.00% ?
    KeyFieldNotInFilter.java ? 0.00% ?
    LimboDocumentChange.java ? 70.59% ?
    ListCollectionIdsRequest.java ? 0.00% ?
    ListCollectionIdsRequestOrBuilder.java ? 0.00% ?
    ListCollectionIdsResponse.java ? 0.00% ?
    ListCollectionIdsResponseOrBuilder.java ? 0.00% ?
    ListDocumentsRequest.java ? 0.00% ?
    ListDocumentsRequestOrBuilder.java ? 0.00% ?
    ListDocumentsResponse.java ? 0.00% ?
    ListDocumentsResponseOrBuilder.java ? 0.00% ?
    ListenRequest.java ? 10.77% ?
    ListenRequestOrBuilder.java ? 0.00% ?
    ListenResponse.java ? 32.64% ?
    ListenResponseOrBuilder.java ? 0.00% ?
    ListenSequence.java ? 100.00% ?
    Listener.java ? 0.00% ?
    ListenerRegistration.java ? 0.00% ?
    ListenerRegistrationImpl.java ? 0.00% ?
    LocalDocumentsView.java ? 100.00% ?
    LocalSerializer.java ? 96.97% ?
    LocalStore.java ? 98.70% ?
    LocalViewChanges.java ? 100.00% ?
    LocalWriteResult.java ? 100.00% ?
    Logger.java ? 75.00% ?
    LruDelegate.java ? 0.00% ?
    LruGarbageCollector.java ? 84.11% ?
    MapValue.java ? 54.00% ?
    MapValueOrBuilder.java ? 0.00% ?
    MaybeDocument.java ? 100.00% ?
    MemoryComponentProvider.java ? 100.00% ?
    MemoryEagerReferenceDelegate.java ? 100.00% ?
    MemoryIndexManager.java ? 100.00% ?
    MemoryLruReferenceDelegate.java ? 96.00% ?
    MemoryMutationQueue.java ? 98.58% ?
    MemoryPersistence.java ? 100.00% ?
    MemoryRemoteDocumentCache.java ? 100.00% ?
    MemoryTargetCache.java ? 100.00% ?
    MetadataChanges.java ? 100.00% ?
    Mutation.java ? 93.75% ?
    MutationBatch.java ? 89.71% ?
    MutationBatchResult.java ? 100.00% ?
    MutationQueue.java ? 0.00% ?
    MutationResult.java ? 100.00% ?
    NoDocument.java ? 57.14% ?
    NotInFilter.java ? 85.71% ?
    NumberComparisonHelper.java ? 100.00% ?
    NumberIndexEncoder.java ? 0.00% ?
    NumberParts.java ? 0.00% ?
    NumericIncrementTransformOperation.java ? 87.50% ?
    ObjectValue.java ? 99.01% ?
    OnlineState.java ? 100.00% ?
    OnlineStateTracker.java ? 100.00% ?
    OrderBy.java ? 96.55% ?
    PatchMutation.java ? 91.11% ?
    Persistence.java ? 100.00% ?
    Precondition.java ? 39.32% ?
    PreconditionOrBuilder.java ? 0.00% ?
    Preconditions.java ? 53.85% ?
    PropertyName.java ? 0.00% ?
    Query.java ? 3.96% ?
    QueryDocumentSnapshot.java ? 64.71% ?
    QueryEngine.java ? 0.00% ?
    QueryListener.java ? 100.00% ?
    QueryProto.java ? 0.00% ?
    QueryPurpose.java ? 100.00% ?
    QueryResult.java ? 100.00% ?
    QuerySnapshot.java ? 76.36% ?
    QueryView.java ? 100.00% ?
    ReferenceDelegate.java ? 0.00% ?
    ReferenceSet.java ? 92.45% ?
    RemoteDocumentCache.java ? 0.00% ?
    RemoteEvent.java ? 92.31% ?
    RemoteSerializer.java ? 83.68% ?
    RemoteStore.java ? 92.15% ?
    ResourcePath.java ? 94.74% ?
    RollbackRequest.java ? 0.00% ?
    RollbackRequestOrBuilder.java ? 0.00% ?
    RunQueryRequest.java ? 0.00% ?
    RunQueryRequestOrBuilder.java ? 0.00% ?
    RunQueryResponse.java ? 0.00% ?
    RunQueryResponseOrBuilder.java ? 0.00% ?
    SQLiteCollectionIndex.java ? 57.14% ?
    SQLiteComponentProvider.java ? 100.00% ?
    SQLiteIndexManager.java ? 100.00% ?
    SQLiteLruReferenceDelegate.java ? 98.63% ?
    SQLiteMutationQueue.java ? 82.66% ?
    SQLitePersistence.java ? 82.87% ?
    SQLiteRemoteDocumentCache.java ? 95.24% ?
    SQLiteSchema.java ? 92.86% ?
    SQLiteTargetCache.java ? 98.47% ?
    ServerTimestamp.java ? 0.00% ?
    ServerTimestampOperation.java ? 100.00% ?
    ServerTimestamps.java ? 79.17% ?
    SetMutation.java ? 80.00% ?
    SetOptions.java ? 0.00% ?
    SimpleQueryEngine.java ? 83.33% ?
    SnapshotMetadata.java ? 68.75% ?
    SnapshotVersion.java ? 93.75% ?
    Source.java ? 0.00% ?
    Stream.java ? 100.00% ?
    StructuredQuery.java ? 33.38% ?
    StructuredQueryOrBuilder.java ? 0.00% ?
    Supplier.java ? 0.00% ?
    SyncEngine.java ? 95.34% ?
    Target.java ? 27.09% ?
    TargetCache.java ? 0.00% ?
    TargetChange.java ? 35.03% ?
    TargetChangeOrBuilder.java ? 0.00% ?
    TargetData.java ? 77.50% ?
    TargetIdGenerator.java ? 100.00% ?
    TargetOrBuilder.java ? 0.00% ?
    TargetState.java ? 97.78% ?
    ThrottledForwardingExecutor.java ? 100.00% ?
    ThrowOnExtraProperties.java ? 0.00% ?
    Timestamp.java ? 90.20% ?
    Token.java ? 0.00% ?
    Transaction.java ? 0.00% ?
    TransactionOptions.java ? 0.00% ?
    TransactionOptionsOrBuilder.java ? 0.00% ?
    TransactionRunner.java ? 0.00% ?
    TransformMutation.java ? 91.57% ?
    TransformOperation.java ? 0.00% ?
    UnknownDocument.java ? 53.85% ?
    UpdateDocumentRequest.java ? 0.00% ?
    UpdateDocumentRequestOrBuilder.java ? 0.00% ?
    User.java ? 78.57% ?
    UserData.java ? 54.37% ?
    UserDataReader.java ? 65.71% ?
    UserDataWriter.java ? 54.72% ?
    Util.java ? 49.35% ?
    Value.java ? 45.65% ?
    ValueOrBuilder.java ? 0.00% ?
    Values.java ? 96.50% ?
    VerifyMutation.java ? 46.15% ?
    View.java ? 96.99% ?
    ViewChange.java ? 100.00% ?
    ViewSnapshot.java ? 88.33% ?
    WatchChange.java ? 70.51% ?
    WatchChangeAggregator.java ? 98.17% ?
    WatchStream.java ? 19.23% ?
    Write.java ? 38.28% ?
    WriteBatch.java ? 0.00% ?
    WriteOrBuilder.java ? 0.00% ?
    WriteProto.java ? 0.00% ?
    WriteRequest.java ? 10.45% ?
    WriteRequestOrBuilder.java ? 0.00% ?
    WriteResponse.java ? 11.76% ?
    WriteResponseOrBuilder.java ? 0.00% ?
    WriteResult.java ? 0.00% ?
    WriteResultOrBuilder.java ? 0.00% ?
    WriteStream.java ? 31.82% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (c9e11401) is created by Prow via merging commits: 22d1615 3c2f680.

@google-oss-bot
Copy link
Contributor

@var-const: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 3c2f680 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wilhuff
wilhuff approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@var-const var-const merged commit 12ae453 into master Sep 29, 2020
@vkryachko
Copy link
Member

@var-const Looks like this PR broke your integ tests, see the device-check-changed failure.

@var-const var-const mentioned this pull request Sep 30, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Oct 30, 2020
@kaibolay kaibolay deleted the varconst/unconditional-user-agent branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@wilhuff wilhuff

Labels
api: firestore cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@var-const @google-oss-bot @vkryachko @wilhuff @googlebot