Skip to content

Add comment to @PublicApi making it clear its only a convention for non-proguarded projects. #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2019
Merged

Add comment to @PublicApi making it clear its only a convention for non-proguarded projects. #263

merged 2 commits into from
Mar 8, 2019

Conversation

mikelehen
Copy link
Contributor

No description provided.

@mikelehen mikelehen requested a review from vkryachko March 8, 2019 17:23
@googlebot googlebot added the cla: yes Override cla label Mar 8, 2019
@google-oss-bot
Copy link
Contributor

@mikelehen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed f17f635 link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

@mikelehen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests-release f17f635 link /test smoke-tests-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

@mikelehen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
connected-check-changed f17f635 link /test connected-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko
Copy link
Member

Please fix gJF failure

@mikelehen
Copy link
Contributor Author

Woops. Fixed, thanks.

@google-oss-bot
Copy link
Contributor

@mikelehen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests-release 273e4f0 link /test smoke-tests-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

@mikelehen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
connected-check-changed 273e4f0 link /test connected-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikelehen mikelehen merged commit 50f1277 into master Mar 8, 2019
@mikelehen mikelehen deleted the mikelehen/comment-publicapi branch March 8, 2019 18:43
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees

@vkryachko vkryachko

Labels
api: core cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikelehen @google-oss-bot @vkryachko @googlebot