Skip to content

Remove unused code #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2021
Merged

Remove unused code #3003

merged 2 commits into from
Sep 28, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

This removes Indexing code that we copied from the backend and did not end up using

@schmidt-sebastian
Remove unused code
f6b7aa0 
This removes Indexing code that we copied from the backend and did not end up using
@googlebot googlebot added the cla: yes Override cla label Sep 24, 2021
@google-cla google-cla bot added the cla: yes Override cla label Sep 24, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 43.15% (d5eec48) to 43.34% (e2fbee32) by +0.18%.

    Filename Base (d5eec48) Head (e2fbee32) Diff
    DeleteMutation.java 90.00% 95.00% +5.00%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e2fbee32) is created by Prow via merging commits: d5eec48 718c741.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (d5eec48) Head (e2fbee32) Diff
    aar 1.20 MB 1.20 MB -3.33 kB (-0.3%)
    apk (release) 3.24 MB 3.24 MB -1.80 kB (-0.1%)

Test Logs

Notes

Head commit (e2fbee32) is created by Prow via merging commits: d5eec48 718c741.

@schmidt-sebastian schmidt-sebastian merged commit a90d3c5 into master Sep 28, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/unused branch September 28, 2021 17:29
@firebase firebase locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @ehsannas @googlebot