Reduce memory usage by applying query check sooner #4591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/AggregateQuery.html 2023-01-30 19:32:26.046202084 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/AggregateQuery.html 2023-01-30 19:31:23.330124939 +0000
@@ -47,7 +47,7 @@
<tr>
<td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html">AggregateQuerySnapshot</a>></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/AggregateSource.html">AggregateSource</a> source)</code></div>
<p>Executes this query.</p>
</td>
</tr>
@@ -122,7 +122,7 @@
</div>
<div><a name="get-com.google.firebase.firestore.AggregateSource-"></a><a name="get"></a>
<h3 class="api-name" id="get(com.google.firebase.firestore.AggregateSource)">get</h3>
- <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html">AggregateQuerySnapshot</a>> <a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source)</pre>
+ <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html">AggregateQuerySnapshot</a>> <a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/AggregateSource.html">AggregateSource</a> source)</pre>
<p>Executes this query.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -133,7 +133,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source</code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/AggregateSource.html">AggregateSource</a> source</code></td>
<td>
<p>The source from which to acquire the aggregate results.</p>
</td>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/AggregateQuery.html 2023-01-30 19:32:26.086202147 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/AggregateQuery.html 2023-01-30 19:31:23.358124994 +0000
@@ -47,7 +47,7 @@
<tr>
<td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html">AggregateQuerySnapshot</a>!></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateSource.html">AggregateSource</a>)</code></div>
<p>Executes this query.</p>
</td>
</tr>
@@ -122,7 +122,7 @@
</div>
<div><a name="get-com.google.firebase.firestore.AggregateSource-"></a><a name="get"></a>
<h3 class="api-name" id="get(com.google.firebase.firestore.AggregateSource)">get</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html">AggregateQuerySnapshot</a>!></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html#get(com.google.firebase.firestore.AggregateSource)">get</a>(source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateSource.html">AggregateSource</a>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html">AggregateQuerySnapshot</a>!></pre>
<p>Executes this query.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -133,7 +133,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
+ <td width="40%"><code>source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateSource.html">AggregateSource</a></code></td>
<td>
<p>The source from which to acquire the aggregate results.</p>
</td> |
…' into wuandy/ApplyQueryToRemoteDocRead
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected ProductsTest Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
…' into wuandy/ApplyQueryToRemoteDocRead
ehsannas
reviewed
Jan 27, 2023
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalStoreTestCase.java
Show resolved
Hide resolved
...firestore/src/test/java/com/google/firebase/firestore/local/RemoteDocumentCacheTestCase.java
Show resolved
Hide resolved
...firestore/src/test/java/com/google/firebase/firestore/local/RemoteDocumentCacheTestCase.java
Show resolved
Hide resolved
wu-hui
commented
Jan 30, 2023
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
...firestore/src/test/java/com/google/firebase/firestore/local/RemoteDocumentCacheTestCase.java
Show resolved
Hide resolved
...firestore/src/test/java/com/google/firebase/firestore/local/RemoteDocumentCacheTestCase.java
Show resolved
Hide resolved
ehsannas
reviewed
Jan 30, 2023
...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java
Outdated
Show resolved
Hide resolved
ehsannas
approved these changes
Jan 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/263835797 for internal tracking