Skip to content

Commit 0085585

Browse files
committed
Fix include files and paths to be compatible with C++ build.
1 parent bfc82c4 commit 0085585

File tree

4 files changed

+13
-17
lines changed

4 files changed

+13
-17
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ option(FIREBASE_INCLUDE_LIBRARY_DEFAULT
2727
"Should each library be included by default." ON)
2828
# Different options to enable/disable each library being included during
2929
# configuration.
30-
option(FIREBASE_INCLUDE_ADMOB "Include the AdMob library."
31-
${FIREBASE_INCLUDE_LIBRARY_DEFAULT})
30+
option(FIREBASE_INCLUDE_ADMOB "Include the AdMob library." OFF)
31+
# ${FIREBASE_INCLUDE_LIBRARY_DEFAULT})
3232
option(FIREBASE_INCLUDE_ANALYTICS
3333
"Include the Google Analytics for Firebase library."
3434
${FIREBASE_INCLUDE_LIBRARY_DEFAULT})

cmake/external/firestore.cmake

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,16 @@ function(GetReleasedDep)
2828
ExternalProject_Add(
2929
firestore
3030

31-
DOWNLOAD_DIR ${FIREBASE_DOWNLOAD_DIR}
32-
GIT_REPOSITORY https://github.com/firebase/firebase-ios-sdk
33-
GIT_TAG 70aa8b82a2ed36dd14448174bea0fd7e575d4d49
34-
GIT_SHALLOW ON
31+
DOWNLOAD_DIR ${FIREBASE_DOWNLOAD_DIR}
32+
URL https://github.com/firebase/firebase-ios-sdk/archive/${version}.tar.gz
3533

3634
PREFIX ${PROJECT_BINARY_DIR}
3735

3836
CONFIGURE_COMMAND ""
3937
BUILD_COMMAND ""
4038
INSTALL_COMMAND ""
4139
TEST_COMMAND ""
42-
PATCH_COMMAND patch -Np1 -i ${CMAKE_CURRENT_LIST_DIR}/firestore_snappy.patch.txt
40+
PATCH_COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_LIST_DIR}/firestore_patch.py --leveldb-version-from ${CMAKE_CURRENT_LIST_DIR}/leveldb.cmake
4341
HTTP_HEADER "${EXTERNAL_PROJECT_HTTP_HEADER}"
4442
)
4543
endfunction()
@@ -60,7 +58,7 @@ function(GetTag t)
6058
BUILD_COMMAND ""
6159
INSTALL_COMMAND ""
6260
TEST_COMMAND ""
63-
PATCH_COMMAND patch -Np1 -i ${CMAKE_CURRENT_LIST_DIR}/firestore_snappy.patch.txt
61+
PATCH_COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_LIST_DIR}/firestore_patch.py --leveldb-version-from ${CMAKE_CURRENT_LIST_DIR}/leveldb.cmake
6462
HTTP_HEADER "${EXTERNAL_PROJECT_HTTP_HEADER}"
6563
)
6664
endfunction()
@@ -76,10 +74,3 @@ else()
7674
endif()
7775
endif()
7876

79-
CONFIGURE_COMMAND ""
80-
BUILD_COMMAND ""
81-
INSTALL_COMMAND ""
82-
TEST_COMMAND ""
83-
PATCH_COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_LIST_DIR}/firestore_patch.py --leveldb-version-from ${CMAKE_CURRENT_LIST_DIR}/leveldb.cmake
84-
HTTP_HEADER "${EXTERNAL_PROJECT_HTTP_HEADER}"
85-
)

firestore/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,8 @@ elseif(IOS)
392392
nanopb
393393
gRPC-C++
394394
gRPC-Core
395-
FirebaseAuth/Interop
395+
FirebaseAuthInterop/FirebaseAuth/Interop
396+
FirebaseCoreExtension/FirebaseCore/Extension
396397
)
397398

398399
if (FIREBASE_XCODE_TARGET_FORMAT STREQUAL "frameworks")

firestore/src/main/create_credentials_provider_ios.mm

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717
#include "firestore/src/main/create_credentials_provider.h"
1818

1919
#import "FIRAuthInterop.h"
20-
#import "FirebaseCoreInternal.h"
20+
#import "FirebaseCore.h"
21+
#import "FIRAppInternal.h"
22+
#import "FIRComponent.h"
23+
#import "FIRComponentContainer.h"
24+
#import "FIRComponentType.h"
2125

2226
#include "Firestore/core/src/credentials/firebase_auth_credentials_provider_apple.h"
2327
#include "absl/memory/memory.h"

0 commit comments

Comments
 (0)