Skip to content

Commit 0848e7a

Browse files
committed
Revert "bundle_test.cc: disable ALL of the tests"
This reverts commit f8e38b1.
1 parent 04b5d8f commit 0848e7a

File tree

1 file changed

+3
-27
lines changed

1 file changed

+3
-27
lines changed

firestore/integration_test_internal/src/bundle_test.cc

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,6 @@ class BundleTest : public FirestoreIntegrationTest {
142142
};
143143

144144
TEST_F(BundleTest, CanLoadBundlesWithoutProgressUpdates) {
145-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
146-
"Actions and needs to be investigated (b/233751585)";
147-
148145
Firestore* db = TestFirestore();
149146
auto bundle = CreateTestBundle(db);
150147

@@ -155,9 +152,6 @@ TEST_F(BundleTest, CanLoadBundlesWithoutProgressUpdates) {
155152
}
156153

157154
TEST_F(BundleTest, CanLoadBundlesWithProgressUpdates) {
158-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
159-
"Actions and needs to be investigated (b/233751585)";
160-
161155
Firestore* db = TestFirestore();
162156
auto bundle = CreateTestBundle(db);
163157

@@ -186,9 +180,6 @@ TEST_F(BundleTest, CanLoadBundlesWithProgressUpdates) {
186180
}
187181

188182
TEST_F(BundleTest, CanDeleteFirestoreFromProgressUpdate) {
189-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
190-
"Actions and needs to be investigated (b/233751585)";
191-
192183
Firestore* db = TestFirestore();
193184
auto bundle = CreateTestBundle(db);
194185

@@ -225,9 +216,6 @@ TEST_F(BundleTest, CanDeleteFirestoreFromProgressUpdate) {
225216
}
226217

227218
TEST_F(BundleTest, LoadBundlesForASecondTimeSkips) {
228-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
229-
"Actions and needs to be investigated (b/233751585)";
230-
231219
// TODO(wuandy): This test fails on Windows CI, but
232220
// local run is fine. We need to figure out why and re-enable it.
233221
SKIP_TEST_ON_WINDOWS;
@@ -256,9 +244,6 @@ TEST_F(BundleTest, LoadBundlesForASecondTimeSkips) {
256244
}
257245

258246
TEST_F(BundleTest, LoadInvalidBundlesShouldFail) {
259-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
260-
"Actions and needs to be investigated (b/233751585)";
261-
262247
// TODO(wuandy): This test fails on Windows CI, but
263248
// local run is fine. We need to figure out why and re-enable it.
264249
SKIP_TEST_ON_WINDOWS;
@@ -288,13 +273,13 @@ TEST_F(BundleTest, LoadInvalidBundlesShouldFail) {
288273
}
289274

290275
TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
291-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
292-
"Actions and needs to be investigated (b/233751585)";
293-
294276
// TODO(wuandy, b/189477267): This test fails on Windows CI, but
295277
// local run is fine. We need to figure out why and re-enable it.
296278
SKIP_TEST_ON_WINDOWS;
297279

280+
GTEST_SKIP() << "This test fails often on Android and iOS in GitHub Actions "
281+
"and needs to be investigated (b/233751585)";
282+
298283
Firestore* db = TestFirestore();
299284
auto collection = db->Collection("coll-1");
300285
WriteDocuments(collection,
@@ -337,9 +322,6 @@ TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
337322
}
338323

339324
TEST_F(BundleTest, LoadedDocumentsShouldNotBeGarbageCollectedRightAway) {
340-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
341-
"Actions and needs to be investigated (b/233751585)";
342-
343325
// TODO(wuandy, b/189477267): This test fails on Windows CI, but
344326
// local run is fine. We need to figure out why and re-enable it.
345327
SKIP_TEST_ON_WINDOWS;
@@ -364,9 +346,6 @@ TEST_F(BundleTest, LoadedDocumentsShouldNotBeGarbageCollectedRightAway) {
364346
}
365347

366348
TEST_F(BundleTest, LoadDocumentsFromOtherProjectsShouldFail) {
367-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
368-
"Actions and needs to be investigated (b/233751585)";
369-
370349
Firestore* db = TestFirestore();
371350
auto bundle = CreateBundle("other-project");
372351
std::vector<LoadBundleTaskProgress> progresses;
@@ -387,9 +366,6 @@ TEST_F(BundleTest, LoadDocumentsFromOtherProjectsShouldFail) {
387366
}
388367

389368
TEST_F(BundleTest, GetInvalidNamedQuery) {
390-
GTEST_SKIP() << "Bundle tests fails often on Android and iOS in GitHub "
391-
"Actions and needs to be investigated (b/233751585)";
392-
393369
Firestore* db = TestFirestore();
394370
{
395371
auto future = db->NamedQuery("DOES_NOT_EXIST");

0 commit comments

Comments
 (0)