Skip to content

Commit 0fd8159

Browse files
committed
Call d8 directly via java instead of by broken shell script.
1 parent 082887d commit 0fd8159

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

.github/workflows/integration_tests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -449,10 +449,6 @@ jobs:
449449
timeout_minutes: 10
450450
max_attempts: 3
451451
command: scripts/gha/install_test_workflow_prereqs.sh -p Android
452-
- name: Fix dexer command line on Windows
453-
if: startsWith(matrix.os, 'windows')
454-
shell: bash
455-
run: sed -i~ 's/-Djava\.ext\.dirs="\%frameworkdir\%"//' "${ANDROID_HOME}/build-tools/*/d8.bat"
456452
- name: Fetch prebuilt packaged SDK from previous run
457453
uses: dawidd6/action-download-artifact@v2
458454
if: ${{ github.event.inputs.test_packaged_sdk != '' }}

android_build_files/extract_and_dex.gradle

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,8 @@ def defineExtractionTasks(String resourceName, String buildType) {
5858
outputs.file "$outPro"
5959

6060
// Convert the jar format using the dx tool.
61-
String dex_path = "${sdk_dir}/build-tools/${buildToolsVersion}/d8"
62-
if (org.gradle.internal.os.OperatingSystem.current().isWindows()) {
63-
dex_path = "${dex_path}.bat"
64-
}
65-
66-
commandLine "${dex_path}",
61+
String dex_path = "${sdk_dir}/build-tools/${buildToolsVersion}/lib/d8.jar"
62+
commandLine "java", "-cp", "${dex_path}", "com.android.tools.r8.D8",
6763
"$buildDir/classes.jar",
6864
"--output",
6965
"$dexedJar"

0 commit comments

Comments
 (0)