Skip to content

Commit 16837e0

Browse files
committed
merged feature/admob_2021
2 parents 8cf3960 + 44e75a0 commit 16837e0

File tree

3 files changed

+35
-36
lines changed

3 files changed

+35
-36
lines changed

admob/integration_test/src/integration_test.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,6 @@ TEST_F(FirebaseAdMobTest, TestInterstitialAdLoad) {
940940
firebase::admob::AdRequest request = GetAdRequest();
941941
WaitForCompletion(interstitial->LoadAd(kInterstitialAdUnit, request),
942942
"LoadAd");
943-
944943
delete interstitial;
945944
}
946945

admob/src/include/firebase/admob/types.h

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,40 @@ struct BoundingBox {
655655
AdView::Position position;
656656
};
657657

658+
/// @brief Listener to be invoked when ads show and dismiss full screen content,
659+
/// such as a fullscreen ad experience or an in-app browser.
660+
class FullScreenContentListener {
661+
public:
662+
virtual ~FullScreenContentListener();
663+
664+
/// Called when the user clicked the ad.
665+
virtual void OnAdClicked();
666+
667+
/// Called when the ad dismissed full screen content.
668+
virtual void OnAdDismissedFullScreenContent();
669+
670+
/// Called when the ad failed to show full screen content.
671+
///
672+
/// param[in] ad_result An object containing detailed information
673+
/// about the error.
674+
virtual void OnAdFailedToShowFullScreenContent(const AdResult& ad_result);
675+
676+
/// Called when an impression is recorded for an ad.
677+
virtual void OnAdImpression();
678+
679+
/// Called when the ad showed the full screen content.
680+
virtual void OnAdShowedFullScreenContent();
681+
};
682+
683+
/// Listener to be invoked when ads have been estimated to earn money.
684+
class PaidEventListener {
685+
public:
686+
virtual ~PaidEventListener();
687+
688+
/// Called when an ad is estimated to have earned money.
689+
virtual void OnPaidEvent(const AdValue& value) = 0;
690+
};
691+
658692
/// Information about an ad response.
659693
class ResponseInfo {
660694
public:
@@ -715,40 +749,6 @@ class LoadAdResult : public AdResult {
715749
ResponseInfo response_info_;
716750
};
717751

718-
/// @brief Listener to be invoked when ads show and dismiss full screen content,
719-
/// such as a fullscreen ad experience or an in-app browser.
720-
class FullScreenContentListener {
721-
public:
722-
virtual ~FullScreenContentListener();
723-
724-
/// Called when the user clicked the ad.
725-
virtual void OnAdClicked();
726-
727-
/// Called when the ad dismissed full screen content.
728-
virtual void OnAdDismissedFullScreenContent();
729-
730-
/// Called when the ad failed to show full screen content.
731-
///
732-
/// param[in] ad_result An object containing detailed information
733-
/// about the error.
734-
virtual void OnAdFailedToShowFullScreenContent(const AdResult& ad_result);
735-
736-
/// Called when an impression is recorded for an ad.
737-
virtual void OnAdImpression();
738-
739-
/// Called when the ad showed the full screen content.
740-
virtual void OnAdShowedFullScreenContent();
741-
};
742-
743-
/// Listener to be invoked when ads have been estimated to earn money.
744-
class PaidEventListener {
745-
public:
746-
virtual ~PaidEventListener();
747-
748-
/// Called when an ad is estimated to have earned money.
749-
virtual void OnPaidEvent(const AdValue& value) = 0;
750-
};
751-
752752
/// @brief Global configuration that will be used for every @ref AdRequest.
753753
/// Set the configuration via @ref SetRequestConfiguration.
754754
struct RequestConfiguration {

admob/src_java/com/google/firebase/admob/internal/cpp/ConstantsHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.google.firebase.admob.internal.cpp;
1818

19-
/**ß
19+
/**
2020
* Helper class containing constants that are shared across the various AdMob ad formats.
2121
*/
2222
public final class ConstantsHelper {

0 commit comments

Comments
 (0)