Skip to content

Commit 25c182f

Browse files
committed
Try disabling warning 4191.
1 parent 1d1bba1 commit 25c182f

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

cmake/external_rules.cmake

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,8 @@ function(build_external_dependencies)
188188
set(CMAKE_SUB_BUILD_OPTIONS ${CMAKE_SUB_BUILD_OPTIONS}
189189
--config Release)
190190
endif()
191+
# On Windows, disable warning 4191: unsafe type conversion
192+
set(disable_warnings "/WD4191")
191193
if(MSVC_RUNTIME_LIBRARY_STATIC)
192194
set(CMAKE_SUB_CONFIGURE_OPTIONS ${CMAKE_SUB_CONFIGURE_OPTIONS}
193195
-DCMAKE_C_FLAGS_RELEASE="/MT"
@@ -196,13 +198,13 @@ function(build_external_dependencies)
196198
-DCMAKE_CXX_FLAGS_DEBUG="/MTd")
197199
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
198200
set(CMAKE_SUB_CONFIGURE_OPTIONS ${CMAKE_SUB_CONFIGURE_OPTIONS}
199-
-DCMAKE_C_FLAGS="/MTd"
200-
-DCMAKE_CXX_FLAGS="/MTd"
201+
-DCMAKE_C_FLAGS="/MTd ${disable_warnings}"
202+
-DCMAKE_CXX_FLAGS="/MTd ${disable_warnings}"
201203
-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDebug)
202204
else()
203205
set(CMAKE_SUB_CONFIGURE_OPTIONS ${CMAKE_SUB_CONFIGURE_OPTIONS}
204-
-DCMAKE_C_FLAGS="/MT"
205-
-DCMAKE_CXX_FLAGS="/MT"
206+
-DCMAKE_C_FLAGS="/MT ${disable_warnings}"
207+
-DCMAKE_CXX_FLAGS="/MT ${disable_warnings}"
206208
-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded)
207209
endif()
208210
else() # dynamic (DLL) runtime
@@ -213,13 +215,13 @@ function(build_external_dependencies)
213215
-DCMAKE_CXX_FLAGS_DEBUG="/MDd")
214216
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
215217
set(CMAKE_SUB_CONFIGURE_OPTIONS ${CMAKE_SUB_CONFIGURE_OPTIONS}
216-
-DCMAKE_C_FLAGS="/MDd"
217-
-DCMAKE_CXX_FLAGS="/MDd"
218+
-DCMAKE_C_FLAGS="/MDd ${disable_warnings}"
219+
-DCMAKE_CXX_FLAGS="/MDd ${disable_warnings}"
218220
-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDebugDLL)
219221
else()
220222
set(CMAKE_SUB_CONFIGURE_OPTIONS ${CMAKE_SUB_CONFIGURE_OPTIONS}
221-
-DCMAKE_C_FLAGS="/MD"
222-
-DCMAKE_CXX_FLAGS="/MD"
223+
-DCMAKE_C_FLAGS="/MD ${disable_warnings}"
224+
-DCMAKE_CXX_FLAGS="/MD ${disable_warnings}"
223225
-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDLL)
224226
endif()
225227
endif()

0 commit comments

Comments
 (0)