Skip to content

Run Firestore tests against Emulators where possible. #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 17, 2021
Merged

Run Firestore tests against Emulators where possible. #549

merged 24 commits into from
Aug 17, 2021

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jul 16, 2021 •
edited
Loading

Firestore tests run against Firestore emulator except:

  • When run from Test Lab
  • Windows (setup Firestore emulator does not work out-of-box), will address in future PR.

@google-cla google-cla bot added the cla: yes label Jul 16, 2021
@wu-hui wu-hui added the tests-requested: quick Trigger a quick set of integration tests. label Jul 16, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 16, 2021
@github-actions
Copy link

github-actions bot commented Jul 16, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @wu-hui on commit b5504d2
Last updated: Tue Aug 17 15:54 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. tests: in-progress This PR's integration tests are in progress. and removed tests: in-progress This PR's integration tests are in progress. labels Jul 16, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 16, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 16, 2021
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jul 26, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 26, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 26, 2021
@wu-hui wu-hui force-pushed the wuandy/FirestoreGoForEmulator branch from c058fec to 55cacb3 Compare August 1, 2021 17:05
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Aug 1, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 1, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 1, 2021
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Aug 6, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 6, 2021
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels Aug 6, 2021
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Aug 16, 2021
@wu-hui wu-hui requested a review from sunmou99 August 16, 2021 13:58
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 16, 2021
@wu-hui wu-hui requested a review from jonsimantov August 16, 2021 15:18
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 16, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 16, 2021
sunmou99
sunmou99 reviewed Aug 16, 2021
View reviewed changes
.github/workflows/integration_tests.yml
if: ${{ !startsWith(matrix.os, 'windows') }}
run: python scripts/gha/desktop_tester.py --testapp_dir testapps --logfile_name "desktop-${{ matrix.os }}-${{ matrix.ssl_variant }}"
env:
USE_FIRESTORE_EMULATOR: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know all the detail. But I was wondering why Non-windows need this env.
Isn't intent.putExtra("USE_FIRESTORE_EMULATOR", "true") enough to set the env?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enough for Android. This is running desktop tests.

Copy link
Contributor

@sunmou99 sunmou99 Aug 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Then why Windows doesn't test agains Firestore emulator?

sunmou99
sunmou99 previously approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please follow up on Firestore Emulator on Windows.

@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Aug 17, 2021
@github-actions github-actions bot dismissed sunmou99’s stale review August 17, 2021 15:37

🍞 Dismissed stale approval on external PR.

@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 17, 2021
@wu-hui
Copy link
Contributor Author

wu-hui commented Aug 17, 2021

LGTM.
Please follow up on Firestore Emulator on Windows.

Please take another look, windows is now supported.

sunmou99
sunmou99 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-hui wu-hui enabled auto-merge (squash) August 17, 2021 19:12
@wu-hui wu-hui removed the tests: failed This PR's integration tests failed. label Aug 17, 2021
@wu-hui wu-hui merged commit b5504d2 into main Aug 17, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Aug 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 17, 2021
@firebase firebase locked and limited conversation to collaborators Sep 17, 2021
@jonsimantov jonsimantov deleted the wuandy/FirestoreGoForEmulator branch December 22, 2021 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees

@jonsimantov jonsimantov

@sunmou99 sunmou99

Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @sunmou99 @jonsimantov