Skip to content

operator== and operator!= for QuerySnapshot. #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2021
Merged

operator== and operator!= for QuerySnapshot. #598

merged 3 commits into from
Aug 12, 2021

Conversation

ehsannas
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Aug 11, 2021
@ehsannas
Copy link
Contributor Author

Note that since we're delegating the actual equality check to the underlying implementation, the newly added test does not cover all possible cases of equality/inequality. It mainly serves as a tool to ensure we do invoke the underlying implementation.

@ehsannas ehsannas self-assigned this Aug 11, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Aug 11, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 11, 2021
@github-actions
Copy link

github-actions bot commented Aug 11, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @ehsannas on commit 6239baf
Last updated: Thu Aug 12 10:00 PDT 2021
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [iOS] [macos] [ios_target]
(1 failed tests)  FirestoreIntegrationTest.TestDocumentSnapshotEventsForAdd
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@ehsannas ehsannas requested a review from var-const August 11, 2021 20:07
@ehsannas ehsannas assigned var-const and unassigned ehsannas Aug 11, 2021
var-const
var-const reviewed Aug 11, 2021
View reviewed changes
@var-const var-const assigned ehsannas and unassigned var-const Aug 11, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 11, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 11, 2021
@var-const
Copy link
Contributor

@ehsannas Oh, and this needs a release note as well.

var-const
var-const previously approved these changes Aug 12, 2021
View reviewed changes
@var-const var-const assigned var-const and unassigned ehsannas Aug 12, 2021
@github-actions github-actions bot dismissed var-const’s stale review August 12, 2021 01:27

🍞 Dismissed stale approval on external PR.

@ehsannas ehsannas requested a review from var-const August 12, 2021 01:28
@ehsannas ehsannas added tests-requested: quick Trigger a quick set of integration tests. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 12, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 12, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 12, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 12, 2021
@ehsannas ehsannas removed the tests: failed This PR's integration tests failed. label Aug 12, 2021
@ehsannas ehsannas merged commit 6239baf into main Aug 12, 2021
@ehsannas ehsannas deleted the ehsann/add-operator-equals-2 branch August 12, 2021 14:53
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Aug 12, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 12, 2021
@firebase firebase locked and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

Assignees

@var-const var-const

Labels
api: firestore cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @var-const