Skip to content

Add a license header to all Firestore files #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2021
Merged

Add a license header to all Firestore files #600

merged 3 commits into from
Aug 13, 2021

Conversation

var-const
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@var-const var-const requested a review from ehsannas August 12, 2021 01:03
@var-const var-const added api: firestore skip-release-notes Skip release notes check labels Aug 12, 2021
ehsannas
ehsannas previously approved these changes Aug 12, 2021
View reviewed changes
@github-actions github-actions bot dismissed ehsannas’s stale review August 12, 2021 01:44

🍞 Dismissed stale approval on external PR.

@var-const var-const requested a review from jonsimantov August 12, 2021 01:44
@var-const var-const assigned jonsimantov and unassigned ehsannas Aug 12, 2021
@var-const
Copy link
Contributor Author

@jonsimantov Jon, can I ask you to take a look at any random file in this PR and see if the license looks good to you? I'm asking because I think you have recently gone through these steps when going through the open-sourcing process. Thanks!

@jonsimantov
Copy link
Contributor

License looks good. I should add a PR check for source files having the license. :)

Will defer approving to @ehsannas.

@jonsimantov
Copy link
Contributor

License looks good. I should add a PR check for source files having the license. :)

Will defer approving to @ehsannas.

Oh never mind I see he already approved. Approving.

@var-const var-const merged commit 11c7349 into main Aug 13, 2021
@var-const var-const deleted the varconst/license branch August 13, 2021 00:03
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Aug 13, 2021
@github-actions
Copy link

github-actions bot commented Aug 13, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @var-const on commit 11c7349
Last updated: Thu Aug 12 19:57 PDT 2021
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [macos] [emulator_target]
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 13, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 13, 2021
@firebase firebase locked and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

@ehsannas ehsannas ehsannas left review comments

Assignees

@jonsimantov jonsimantov

Labels
api: firestore cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@var-const @jonsimantov @ehsannas