Skip to content

Define new error codes for passthrough errors. #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Conversation

rosalyntan
Copy link
Member

Add ERROR_UNSUPPORTED_PASSTHROUGH_OPERATION and ERROR_TOKEN_REFRESH_UNAVAILABLE error codes.

Note: Also fixed a typo in the C++ error code mapping for ERROR_USER_CANCELLED.

Corresponding Android change in cl/385610798.

@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@rosalyntan rosalyntan added the skip-release-notes Skip release notes check label Aug 12, 2021
@rosalyntan rosalyntan merged commit 92db798 into main Aug 13, 2021
@rosalyntan rosalyntan deleted the rosalyntan.errorcode branch August 13, 2021 17:27
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Aug 13, 2021
@github-actions
Copy link

github-actions bot commented Aug 13, 2021

❌  Integration test FAILED

Requested by @rosalyntan on commit 92db798
Last updated: Fri Aug 13 12:57 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 13, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 13, 2021
@firebase firebase locked and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants