Skip to content

Private function to get Hash() for QuerySnapshot, DocumentSnapshot,… #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2021
Merged

Private function to get Hash() for QuerySnapshot, DocumentSnapshot,… #619

merged 1 commit into from
Aug 26, 2021

Conversation

ehsannas
Copy link
Contributor

… and DocumentChange.

@ehsannas ehsannas added the skip-release-notes Skip release notes check label Aug 25, 2021
@ehsannas ehsannas requested a review from var-const August 25, 2021 21:01
@google-cla google-cla bot added the cla: yes label Aug 25, 2021
@var-const var-const assigned ehsannas and unassigned var-const Aug 25, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Aug 26, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Aug 26, 2021
@github-actions
Copy link

github-actions bot commented Aug 26, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @ehsannas on commit 7616961
Last updated: Thu Aug 26 10:46 PDT 2021
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [iOS] [macos] [ios_target]
messaging [TEST] [ERROR] [Android] [All os] [android_target]
storage [TEST] [FAILURE] [iOS] [macos] [ios_target]
(1 failed tests)  FirebaseStorageTest.TestWriteAndReadFileWithCustomMetadata

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Aug 26, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 26, 2021
@ehsannas ehsannas merged commit 7616961 into main Aug 26, 2021
@ehsannas ehsannas deleted the ehsann/add-hash-querysnapshot branch August 26, 2021 14:28
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 26, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 26, 2021
@firebase firebase locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @var-const