Skip to content

Fix: Moving a local object in a return statement prevents copy elision #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas requested a review from var-const August 26, 2021 15:09
@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@ehsannas ehsannas added the skip-release-notes Skip release notes check label Aug 26, 2021
@var-const var-const assigned ehsannas and unassigned var-const Aug 26, 2021
@ehsannas ehsannas added skip-release-notes Skip release notes check and removed skip-release-notes Skip release notes check labels Aug 26, 2021
@ehsannas ehsannas merged commit 2c5d663 into main Aug 26, 2021
@ehsannas ehsannas deleted the ehsann/remove-move branch August 26, 2021 18:35
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Aug 26, 2021
@github-actions
Copy link

github-actions bot commented Aug 26, 2021

❌  Integration test FAILED

Requested by @ehsannas on commit 2c5d663
Last updated: Thu Aug 26 14:51 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 26, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 26, 2021
@firebase firebase locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants