iOS Baseline to build upon for the Admob 2021 SDK #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit c94129f
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
DellaBitta
added a commit
that referenced
this pull request
Sep 21, 2021
* Android pinned to new version * Updates to Admob Android to reduce usage of BannerViewHelper.java (#624) * removed some BannerViewHelper code, the rest requires upcoming listener revamp * added <string.h> include to banner_view_internal_android.cc * iOS Baseline to build upon for the Admob 2021 SDK (#625) * removed nativeAdExpress and rewardedVideo iOS impls * removed extra comma in admob testapp project * fixed lint errors * linting fixes * add new line to the end of BannerViewHelper.java * update use of futures in initialization * Updated error string * Fix request builder Android leak * check completions in both directions * format fixes * Skip AlreadyInitialized on Desktop
DellaBitta
added a commit
that referenced
this pull request
Sep 22, 2021
* Android pinned to new version * Updates to Admob Android to reduce usage of BannerViewHelper.java (#624) * removed some BannerViewHelper code, the rest requires upcoming listener revamp * added <string.h> include to banner_view_internal_android.cc * iOS Baseline to build upon for the Admob 2021 SDK (#625) * removed nativeAdExpress and rewardedVideo iOS impls * removed extra comma in admob testapp project * fixed lint errors * linting fixes * add new line to the end of BannerViewHelper.java * ios set configuration impl * Integration test on iOS * desktop integration test passes * Android implementation and tests pass * lint fixes * lint fixes * lint fixes * copy paste error * desktop test fix * updated NSArrayOfNSStringToVectorOfString name * removed test device ids from request converter. Missed on merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.