Skip to content

Add workflow to automatically update iOS and Android dependencies. #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Sep 10, 2021
Merged

Add workflow to automatically update iOS and Android dependencies. #629

merged 47 commits into from
Sep 10, 2021

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Sep 8, 2021 •
edited
Loading

This workflow will:

  • Check out the repo and create a branch
  • Update the iOS and/or Android dependencies in that branch
  • Push the branch to GitHub
  • Create a PR on the branch
  • Trigger integration tests to run on the PR (via label)

For now, to use, go to "Actions", select the "Update Android and iOS dependencies" workflow, and use workflow_dispatch to run the workflow. In most cases, the default inputs should be fine (after this PR goes in).

@google-cla google-cla bot added the cla: yes label Sep 8, 2021
@jonsimantov jonsimantov changed the title Automatically update iOS and Android dependencies. Add workflow to automatically update iOS and Android dependencies. Sep 8, 2021
@jonsimantov
Copy link
Contributor Author

This is now ready for review!

Sample run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/1215602717
Sample PR created by this workflow: #645

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Sep 9, 2021
DellaBitta
DellaBitta requested changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check admob's dependency version.

@jonsimantov
Copy link
Contributor Author

jonsimantov commented Sep 10, 2021 •
edited
Loading

New sample PR: #648

@jonsimantov
Copy link
Contributor Author

Double check admob's dependency version.

It's just using the AdMob version set by default in update_android_ios_dependencies.py - when this needs to change, that script should be modified.

@jonsimantov jonsimantov merged commit 0fa1bd7 into main Sep 10, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 10, 2021
@github-actions
Copy link

github-actions bot commented Sep 10, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 0fa1bd7
Last updated: Fri Sep 10 15:52 PDT 2021
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [iOS] [macos] [simulator_target]
database [TEST] [ERROR] [Android] [windows] [android_target]
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 10, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 10, 2021
@jonsimantov jonsimantov deleted the feature/auto-update-dependencies branch September 24, 2021 16:56
@firebase firebase locked and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@a-maurice a-maurice Awaiting requested review from a-maurice

Assignees
No one assigned
Labels
cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @DellaBitta