Skip to content

Move Pull Request Template for Auto Population #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

DellaBitta
Copy link
Contributor

We have a pull request template that was placed in a directory which github uses to support multiple different pull request templates. However that directory doesn't seem to trigger to default our pull requests to use the only template in there. Instead following these directions to put the pull request template in the base directory.

@DellaBitta DellaBitta added no-lint Skip lint checks skip-release-notes Skip release notes check labels Sep 27, 2021
@DellaBitta DellaBitta merged commit 6b465d7 into main Sep 28, 2021
@DellaBitta DellaBitta deleted the feature/pull_request_template branch September 28, 2021 15:10
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 28, 2021
@github-actions
Copy link

github-actions bot commented Sep 28, 2021

❌  Integration test FAILED

Requested by @DellaBitta on commit 6b465d7
Last updated: Tue Sep 28 10:40 PDT 2021
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Android] [macos]
firestore [TEST] [FAILURE] [Android] [ubuntu] [emulator_target]
(1 failed tests)  FirestoreIntegrationTest.AuthWorks
messaging [TEST] [ERROR] [Android] [ubuntu] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 28, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 28, 2021
@firebase firebase locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-lint Skip lint checks skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants