Skip to content

Rename Admob LeaderBoard AdSize to Leaderboard #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

Rename Admob LeaderBoard AdSize to Leaderboard #754

merged 1 commit into from
Nov 24, 2021

Conversation

DellaBitta
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Simply rename the constant to match AdMob naming conventions.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

CI Tests only.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@google-cla google-cla bot added the cla: yes label Nov 22, 2021
@DellaBitta DellaBitta changed the title Rename Admob AdSize from LeaderBoard to Leaderboard Rename Admob LeaderBoard AdSize to Leaderboard Nov 22, 2021
@DellaBitta DellaBitta merged commit b57f5a7 into feature/admob_2021 Nov 24, 2021
@DellaBitta DellaBitta deleted the feature/admob_2021_leaderboard branch November 24, 2021 14:29
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 24, 2021
@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @DellaBitta on commit b57f5a7
Last updated: Wed Nov 24 09:09 PST 2021
View integration test log & download artifacts

Failures Configs
admob [TEST] [ERROR] [Android] [windows, macos] [android_target]
functions [TEST] [FAILURE] [iOS] [macos] [ios_target]
(1 failed tests)  FirebaseFunctionsTest.TestErrorHandling

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 24, 2021
@firebase firebase locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @jonsimantov