Skip to content

Rename Admob LeaderBoard AdSize to Leaderboard #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Rename Admob LeaderBoard AdSize to Leaderboard #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admob/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ TEST_F(FirebaseAdMobTest, TestAdSize) {
EXPECT_EQ(fullbanner.type(), AdSize::kTypeStandard);
EXPECT_EQ(fullbanner.orientation(), AdSize::kOrientationCurrent);

const AdSize leaderboard = AdSize::kLeaderBoard;
const AdSize leaderboard = AdSize::kLeaderboard;
EXPECT_EQ(leaderboard.width(), 728);
EXPECT_EQ(leaderboard.height(), 90);
EXPECT_EQ(leaderboard.type(), AdSize::kTypeStandard);
Expand Down
2 changes: 1 addition & 1 deletion admob/src/common/admob_common.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ AdResult AdMobInternal::CreateAdResult(
const AdSize AdSize::kBanner(/*width=*/320, /*height=*/50);
const AdSize AdSize::kFullBanner(468, 60);
const AdSize AdSize::kLargeBanner(320, 100);
const AdSize AdSize::kLeaderBoard(728, 90);
const AdSize AdSize::kLeaderboard(728, 90);
const AdSize AdSize::kMediumRectangle(300, 250);

AdSize::AdSize(uint32_t width, uint32_t height)
Expand Down
2 changes: 1 addition & 1 deletion admob/src/include/firebase/admob/types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ class AdSize {

/// Interactive Advertising Bureau (IAB) leaderboard ad size
/// (728x90 density-independent pixels).
static const AdSize kLeaderBoard;
static const AdSize kLeaderboard;

/// Interactive Advertising Bureau (IAB) medium rectangle ad size
/// (300x250 density-independent pixels).
Expand Down