Skip to content

Update VCPKG March 2022 #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

Update VCPKG March 2022 #876

merged 1 commit into from
Mar 30, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Mar 29, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

vcpkg would fail to install on windows runners building android targets. This similar external issue hints at updating vcpkg, which seems to have done the trick.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta marked this pull request as ready for review March 29, 2022 19:58
@DellaBitta DellaBitta requested a review from jonsimantov March 29, 2022 19:58
@DellaBitta DellaBitta added the tests-requested: quick Trigger a quick set of integration tests. label Mar 29, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 29, 2022
@firebase firebase deleted a comment from github-actions bot Mar 29, 2022
@DellaBitta DellaBitta removed the tests: in-progress This PR's integration tests are in progress. label Mar 29, 2022
@DellaBitta
Copy link
Contributor Author

itests didn't trigger because no sources were updated. Running them manually. Link.

@DellaBitta DellaBitta added the skip-release-notes Skip release notes check label Mar 29, 2022
@DellaBitta DellaBitta merged commit 96ce195 into main Mar 30, 2022
@DellaBitta DellaBitta deleted the ddb/update-vcpkg branch March 30, 2022 12:39
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 30, 2022
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @DellaBitta on commit 96ce195
Last updated: Wed Mar 30 08:21 PDT 2022
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Android] [1/3 os: windows]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  QueryTest.TestCanListenForTheSameQueryWithDifferentOptions
remote_config [TEST] [FAILURE] [Linux] [openssl]
(2 failed tests)  FirebaseRemoteConfigTest.TestFetch
  FirebaseRemoteConfigTest.TestGetAll

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 30, 2022
@dconeybe dconeybe mentioned this pull request Mar 31, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @jonsimantov