Skip to content

update gradle version #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2022
Merged

update gradle version #924

merged 2 commits into from
May 5, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 4, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Update from a very old Gradle version (4.10.1) to a slightly less old version (5.6.4) to fix some Android build errors, as new Firebase Android dependencies require a newer version.

Gradle 6.x and up cause a build error in our Proguard generator that will need to be addressed before updating further.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 4, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 0b25524
Last updated: Wed May 4 19:25 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [android_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [FLAKINESS] [Android] [1/3 os: macos] [android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 4, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 4, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 4, 2022
@jonsimantov jonsimantov changed the title update gradle version to 6.5.1 update gradle version May 4, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 4, 2022
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label May 4, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) May 4, 2022 22:19
chkuang-g
chkuang-g reviewed May 4, 2022
View reviewed changes
admob/integration_test/gradle/wrapper/gradle-wrapper.properties
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip
distributionUrl=https://services.gradle.org/distributions/gradle-5.6.4-all.zip
Copy link
Contributor

@chkuang-g chkuang-g May 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why it was https\:// before.

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 5, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2022
@jonsimantov jonsimantov merged commit 0b25524 into main May 5, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 5, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2022
@jonsimantov jonsimantov deleted the bugfix/gradle-version branch May 6, 2022 16:49
@jonsimantov jonsimantov mentioned this pull request May 10, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chkuang-g chkuang-g chkuang-g left review comments

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@sunmou99 sunmou99 Awaiting requested review from sunmou99

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonsimantov @cynthiajoan @chkuang-g