Skip to content

Fix Windows boringssl build by disabling warning 4191. #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2022
Merged

Fix Windows boringssl build by disabling warning 4191. #956

merged 5 commits into from
May 13, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 12, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

GitHub Windows build for boringssl is now failing on warning C4191 being treated as error. Add this warning to the ignored warnings list.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run integration test on expanded matrix.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov changed the title Try disabling warning 4191. Fix Windows boringssl build by disabling warning 4191. May 12, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 12, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 12, 2022
@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit c651636
Last updated: Fri May 13 08:04 PDT 2022
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
storage [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 12, 2022
@github-actions github-actions bot removed the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 12, 2022
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 12, 2022
@github-actions github-actions bot removed the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 12, 2022
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 12, 2022
@jonsimantov jonsimantov requested a review from DellaBitta May 12, 2022 23:56
@github-actions github-actions bot removed the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 12, 2022
jonsimantov
jonsimantov commented May 12, 2022
View reviewed changes
scripts/git/patches/boringssl/0001-disable-warnings.patch
@@ -1,25 +1,13 @@
From 831806231dd360278dac2a37e3c3158420ad7bb3 Mon Sep 17 00:00:00 2001
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the patch hand-edited, I had to remove the Git-specific stuff from it and make it a normal patch file.

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 13, 2022
@jonsimantov jonsimantov added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels May 13, 2022
@github-actions github-actions bot removed the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 13, 2022
@jonsimantov jonsimantov marked this pull request as ready for review May 13, 2022 00:21
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label May 13, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) May 13, 2022 00:24
@jonsimantov jonsimantov disabled auto-merge May 13, 2022 00:24
@jonsimantov jonsimantov enabled auto-merge (squash) May 13, 2022 00:24
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 13, 2022
@DellaBitta
Copy link
Contributor

Awesome, thanks for doing this overnight!

@jonsimantov jonsimantov merged commit c651636 into main May 13, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels May 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 13, 2022
@jonsimantov jonsimantov deleted the bugfix/fix-windows-boringssl-build branch May 13, 2022 18:36
@firebase firebase locked and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @DellaBitta