Skip to content

admob 2021 merge main with cleanup #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

admob 2021 merge main with cleanup #959

wants to merge 9 commits into from

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 13, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels May 13, 2022
@github-actions
Copy link

github-actions bot commented May 13, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit fc0b119
Last updated: Sat May 14 00:30 PDT 2022
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [iOS] [macos] [1/6 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/5 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/5 android_device: android_latest]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [FLAKINESS] [iOS] [macos] [1/6 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
gma
(4 items)[TEST] [ERROR] [Android] [1/3 os: ubuntu] [2/5 android_device: emulator_target emulator_latest]
[TEST] [ERROR] [Android] [2/3 os: macos windows] [1/5 android_device: emulator_32bit]
[TEST] [ERROR] [iOS] [macos] [All 3 Simulators]
[TEST] [FAILURE] [Android] [All 3 os] [All 2 FTL Devices]
(1 failed tests)  FirebaseGmaTest.TestAdView

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 13, 2022
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 13, 2022
@github-actions github-actions bot removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels May 13, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 14, 2022
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 14, 2022
@github-actions github-actions bot removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels May 14, 2022
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 14, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels May 14, 2022
@jonsimantov jonsimantov requested a review from DellaBitta May 14, 2022 06:10
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 14, 2022
@DellaBitta
Copy link
Contributor

Code looks right to me but Android doesn't seem to like it. Is that due to the -f PIC settings?

@jonsimantov jonsimantov mentioned this pull request May 16, 2022
Merged
3 tasks
@firebase firebase locked and limited conversation to collaborators Jun 16, 2022
@DellaBitta DellaBitta deleted the feature/admob_2021_merge_main_with_cleanup branch June 22, 2022 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonsimantov @DellaBitta @a-maurice