Skip to content

Update the nodejs version to 14, for Firebase CLI #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Update the nodejs version to 14, since the Firebase CLI seems to require it now.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label May 19, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 19, 2022
@github-actions
Copy link

github-actions bot commented May 19, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit 091a0d7
Last updated: Thu May 19 20:10 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore
(5 items)[TEST] [ERROR] [Android] [All 2 os] [emulator_target]
[TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/2 os: ubuntu] [android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@a-maurice a-maurice added the skip-release-notes Skip release notes check label May 19, 2022
@a-maurice a-maurice requested a review from sunmou99 May 19, 2022 22:46
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-maurice a-maurice removed the tests: in-progress This PR's integration tests are in progress. label May 19, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 19, 2022
@a-maurice a-maurice merged commit 091a0d7 into main May 19, 2022
@a-maurice a-maurice deleted the am-node_js branch May 19, 2022 23:41
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels May 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 20, 2022
@firebase firebase locked and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants