Skip to content

Add GetHttpsCallableFromURL to Functions #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2022
Merged

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Adds GetHttpsCallableFromURL to the Functions SDK. This was recently added to both the Android and iOS SDKs.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running the testapps on mobile and desktop locally with the changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice requested a review from DellaBitta May 20, 2022 23:52
@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label May 20, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit a192efb
Last updated: Tue May 24 16:39 PDT 2022
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Android] [1/3 os: windows]
analytics [BUILD] [ERROR] [Android] [1/3 os: windows]
auth [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseAuthTest.TestUpdateEmailAndPassword
firestore
(4 items)[TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: emulator_target]
[TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 21, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 21, 2022
@a-maurice a-maurice removed the tests: failed This PR's integration tests failed. label May 24, 2022
@a-maurice
Copy link
Contributor Author

a-maurice commented May 24, 2022

The failed tests seem to be flaky ones in Firestore, and unrelated to this change.

@a-maurice a-maurice merged commit a192efb into main May 24, 2022
@a-maurice a-maurice deleted the am-functions_custom_urls branch May 24, 2022 20:08
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels May 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 24, 2022
@firebase firebase locked and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants