-
Notifications
You must be signed in to change notification settings - Fork 124
Support git longpaths #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Integration test FAILEDRequested by @wu-hui on commit 61d6ff9
Add flaky tests to go/fpl-cpp-flake-tracker |
Build passed, but there are some test failures and at a glance they seem to be related to the python script you are working on @dconeybe ? |
… wuandy/WinLongPath
.github/workflows/android.yml
Outdated
@@ -62,6 +62,10 @@ jobs: | |||
git config --global credential.helper 'store --file /tmp/git-credentials' | |||
echo 'https://${{ github.token }}@github.com' > /tmp/git-credentials | |||
|
|||
- name: Support Longpaths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ultranit: Mention "Git" in the name here, just so it makes more sense when someone sees this out of context.
e.g. "Support Longpaths" -> "Enable Git Longpaths Support"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM. I've merge in the latest changes from the main branch, which may fix the integration tests. Those failures don't look familiar to me, but we can take a look after seeing what happens with the latest changes from main. |
build-desktop-windows-latest-x64-openssl is indeed failing due to the python virtualenv setup (https://github.com/firebase/firebase-ios-sdk/blob/06185f630e9a3a7594a9ab6b748abaf07bf50466/cmake/python_setup.cmake). It's weird because, according to the logs, the One guess is that there is a bug/feature in the particular version of cmake being used. I'm going to modify the build to print the cmake version to see if I can reproduce with whatever version is in use. |
firebase/firebase-ios-sdk#9851 fixes the problematic usage of designated initialization in |
… wuandy/WinLongPath
…e beginning of the build" This reverts commit c290276.
… wuandy/WinLongPath
… wuandy/WinLongPath
No description provided.