Skip to content

Remove unused/redundant steps in Integration Test CI #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 22, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Jun 16, 2022

Description

Removed Uploaded Testapp Artifacts to GCloud.
Removed restore_secrets steps in test jobs.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@sunmou99 sunmou99 marked this pull request as ready for review June 21, 2022 18:47
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jun 21, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 21, 2022
@github-actions
Copy link

github-actions bot commented Jun 21, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @sunmou99 on commit 2c8ddbe
Last updated: Wed Jun 22 13:36 PDT 2022
View integration test log & download artifacts

Failures Configs
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(2 failed tests)  FirebaseRemoteConfigTest.TestFetch
  FirebaseRemoteConfigTest.TestGetAll

Add flaky tests to go/fpl-cpp-flake-tracker

@sunmou99 sunmou99 added the skip-release-notes Skip release notes check label Jun 21, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 21, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 21, 2022
python scripts/gha/test_lab.py --testapp_dir testapps \
--android_device "${{ matrix.android_device }}" \
--logfile_name "android-${{ matrix.build_os }}-${{ matrix.android_device }}" \
--code_platform cpp \
--key_file scripts/gha-encrypted/gcs_key_file.json
--key_file_encrypted scripts/gha-encrypted/gcs_key_file.json.gpg \
--key_file_passphrase "${{ secrets.TEST_SECRET }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have be this PR, but we probably should rename it to more meaningful

@sunmou99 sunmou99 merged commit 2c8ddbe into main Jun 22, 2022
@sunmou99 sunmou99 deleted the feature/it-delete-steps branch June 22, 2022 17:44
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 22, 2022
@firebase firebase locked and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants