Skip to content

Commit 31430c9

Browse files
committed
Update node versions on CI tests.
1 parent 3e7a4b7 commit 31430c9

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

.github/workflows/postmerge.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- uses: actions/checkout@v3
3535
- uses: actions/setup-node@v3
3636
with:
37-
node-version: 16
37+
node-version: 18
3838

3939
- uses: google-github-actions/auth@v0
4040
with:

.github/workflows/test.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ jobs:
3030
strategy:
3131
matrix:
3232
node-version:
33-
- 14.x
34-
- 16.x
3533
- 18.x
34+
- 20.x
3635
steps:
3736
- uses: actions/checkout@v1
3837
- uses: actions/setup-node@v1
@@ -51,9 +50,8 @@ jobs:
5150
strategy:
5251
matrix:
5352
node-version:
54-
- 14.x
55-
- 16.x
5653
- 18.x
54+
- 20.x
5755
steps:
5856
- uses: actions/checkout@v1
5957
- uses: actions/setup-node@v1

scripts/bin-test/run.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ for f in scripts/bin-test/sources/*; do
1212
fi
1313
done
1414

15-
## DEBUG
16-
ls -la scripts/bin-test/sources/commonjs/node_modules
15+
# Make sure firebase-functions binary is executable
16+
chmod +x ./lib/bin/firebase-functions.js
1717

1818
mocha \
1919
--file ./scripts/bin-test/mocha-setup.ts \

0 commit comments

Comments
 (0)