Skip to content

Commit 067de13

Browse files
committed
Address Firestore review feedback
1 parent 9401953 commit 067de13

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Firestore/Source/API/FIRFirestoreVersion.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@
2222

2323
// Because `kFirestoreVersionString` is subject to constant initialization, this
2424
// is not affected by static initialization order fiasco.
25-
extern "C" const char *const FIRFirestoreVersionString = (const char *const)kFirestoreVersionString;
25+
extern "C" const char *const FIRFirestoreVersionString = kFirestoreVersionString;

Firestore/core/test/firebase/firestore/auth/firebase_credentials_provider_test.mm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include "Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.h"
1818

1919
#import <FirebaseAuthInterop/FIRAuthInterop.h>
20+
#import <FirebaseCore/FIRApp.h>
2021

2122
#include <chrono> // NOLINT(build/c++11)
2223
#include <future> // NOLINT(build/c++11)

0 commit comments

Comments
 (0)