Skip to content

Commit 18ce7ba

Browse files
ddnanmikehaney24
andauthored
Fixed iOS testapp dark mode (#4812)
* Fixed iOS testapp dark mode * Fixed dark mode display on normal GDT iOS testapp * Fix unwrapping an optional for the GDT macOS test app Co-authored-by: Michael Haney <[email protected]>
1 parent 827e6be commit 18ce7ba

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

GoogleDataTransport/GDTTestApp/app.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@ import GoogleDataTransport
4444
}
4545

4646
public class ViewController: NSViewController {
47-
let transport: GDTCORTransport = GDTCORTransport(mappingID: "1234", transformers: nil, target: GDTCORTarget.test.rawValue)
47+
let transport: GDTCORTransport = GDTCORTransport(mappingID: "1234", transformers: nil, target: GDTCORTarget.test.rawValue)!
4848
}
4949
#endif

GoogleDataTransport/GDTTestApp/ios/Main.storyboard

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14490.70" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="BYZ-38-t0r">
3-
<device id="retina6_1" orientation="portrait">
4-
<adaptation id="fullscreen"/>
5-
</device>
2+
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="15702" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="BYZ-38-t0r">
3+
<device id="retina6_1" orientation="portrait" appearance="dark"/>
64
<dependencies>
75
<deployment identifier="iOS"/>
8-
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="14490.49"/>
6+
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="15704"/>
97
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
108
</dependencies>
119
<scenes>
@@ -22,7 +20,7 @@
2220
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
2321
<subviews>
2422
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="674-uo-mtw">
25-
<rect key="frame" x="20" y="74" width="555" height="55"/>
23+
<rect key="frame" x="20" y="98" width="369" height="55"/>
2624
<color key="backgroundColor" white="0.66666666666666663" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
2725
<constraints>
2826
<constraint firstAttribute="height" constant="55" id="xfr-R6-SiR"/>
@@ -35,7 +33,7 @@
3533
</connections>
3634
</button>
3735
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="FD9-Mn-in7">
38-
<rect key="frame" x="20" y="137" width="555" height="55"/>
36+
<rect key="frame" x="20" y="161" width="369" height="55"/>
3937
<color key="backgroundColor" white="0.66666666669999997" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
4038
<constraints>
4139
<constraint firstAttribute="height" constant="55" id="0Uy-Mh-vns"/>
@@ -48,7 +46,7 @@
4846
</connections>
4947
</button>
5048
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="IFu-Rf-wNA">
51-
<rect key="frame" x="20" y="200" width="555" height="55"/>
49+
<rect key="frame" x="20" y="224" width="369" height="55"/>
5250
<color key="backgroundColor" white="0.66666666669999997" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
5351
<constraints>
5452
<constraint firstAttribute="height" constant="55" id="SQB-HZ-Idj"/>
@@ -61,7 +59,7 @@
6159
</connections>
6260
</button>
6361
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="yTs-B1-Yoh">
64-
<rect key="frame" x="20" y="263" width="555" height="55"/>
62+
<rect key="frame" x="20" y="287" width="369" height="55"/>
6563
<color key="backgroundColor" white="0.66666666669999997" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
6664
<constraints>
6765
<constraint firstAttribute="height" constant="55" id="GCn-oJ-52K"/>
@@ -74,13 +72,13 @@
7472
</connections>
7573
</button>
7674
<label opaque="NO" userInteractionEnabled="NO" contentMode="center" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="GoogleDataTransport Test App" textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="L83-mC-jNW">
77-
<rect key="frame" x="20" y="28" width="236" height="21"/>
75+
<rect key="frame" x="20" y="52" width="236" height="21"/>
7876
<fontDescription key="fontDescription" type="system" pointSize="17"/>
7977
<nil key="textColor"/>
8078
<nil key="highlightedColor"/>
8179
</label>
8280
<button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="QpN-cI-JZa">
83-
<rect key="frame" x="20" y="326" width="555" height="55"/>
81+
<rect key="frame" x="20" y="350" width="369" height="55"/>
8482
<color key="backgroundColor" white="0.66666666669999997" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
8583
<constraints>
8684
<constraint firstAttribute="height" constant="55" id="U3o-sp-jte"/>
@@ -93,7 +91,7 @@
9391
</connections>
9492
</button>
9593
</subviews>
96-
<color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
94+
<color key="backgroundColor" cocoaTouchSystemColor="groupTableViewBackgroundColor"/>
9795
<constraints>
9896
<constraint firstItem="FD9-Mn-in7" firstAttribute="trailing" secondItem="674-uo-mtw" secondAttribute="trailing" id="6RX-nn-nw3"/>
9997
<constraint firstItem="FD9-Mn-in7" firstAttribute="leading" secondItem="674-uo-mtw" secondAttribute="leading" id="6rB-CC-4ri"/>

GoogleDataTransportCCTSupport/GDTCCTTestApp/ios/Main.storyboard

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
</label>
2828
<segmentedControl opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="left" contentVerticalAlignment="top" segmentControlStyle="plain" selectedSegmentIndex="0" translatesAutoresizingMaskIntoConstraints="NO" id="9fC-1b-Rvu">
2929
<rect key="frame" x="20" y="37" width="140" height="32"/>
30+
<color key="backgroundColor" systemColor="opaqueSeparatorColor" red="0.77647058820000003" green="0.77647058820000003" blue="0.7843137255" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
3031
<segments>
3132
<segment title="CCT"/>
3233
<segment title="FLL"/>
@@ -100,7 +101,7 @@
100101
</connections>
101102
</button>
102103
</subviews>
103-
<color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
104+
<color key="backgroundColor" cocoaTouchSystemColor="groupTableViewBackgroundColor"/>
104105
<constraints>
105106
<constraint firstItem="674-uo-mtw" firstAttribute="leading" secondItem="FD9-Mn-in7" secondAttribute="leading" id="2MG-RM-cIL"/>
106107
<constraint firstItem="yTs-B1-Yoh" firstAttribute="leading" secondItem="QpN-cI-JZa" secondAttribute="leading" id="3AV-qq-ttG"/>

0 commit comments

Comments
 (0)