Skip to content

Commit 2b7ffaa

Browse files
schmidt-sebastianpaulb777
authored andcommitted
Remove log argument that causes SocketRocket crash (#3983)
1 parent 7235f8f commit 2b7ffaa

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Firebase/Database/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Unreleased
2+
- [fixed] Fixed an iOS 13 crash that occured in our WebSocket error handling. (#3950)
23

34
# v6.1.0
45
- [fixed] Fix Catalyst Build issue. (#3512)

Firebase/Database/third_party/SocketRocket/FSRWebSocket.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1510,7 +1510,9 @@ - (void)safeHandleEvent:(NSStreamEvent)eventCode stream:(NSStream *)aStream
15101510
}
15111511

15121512
case NSStreamEventErrorOccurred: {
1513-
SRFastLog(@"NSStreamEventErrorOccurred %@ %@", aStream, [[aStream streamError] copy]);
1513+
// Note: The upstream code for SocketRocket logs the error message, but this causes
1514+
// crashes on iOS 13 (https://github.com/firebase/firebase-ios-sdk/issues/3950)
1515+
SRFastLog(@"NSStreamEventErrorOccurred %@", aStream);
15141516
/// TODO specify error better!
15151517
[self _failWithError:aStream.streamError];
15161518
_readBufferOffset = 0;

0 commit comments

Comments
 (0)