Skip to content

Commit 3b40fa7

Browse files
committed
More review feedback
1 parent 97b6700 commit 3b40fa7

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

Firestore/core/src/firebase/firestore/local/leveldb_key.h

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ class LevelDbMutationKey {
132132
}
133133

134134
private:
135+
// Deliberately uninitialized: will be assigned in Decode
135136
std::string user_id_;
136137
model::BatchId batch_id_;
137138
};
@@ -199,6 +200,7 @@ class LevelDbDocumentMutationKey {
199200
}
200201

201202
private:
203+
// Deliberately uninitialized: will be assigned in Decode
202204
std::string user_id_;
203205
model::DocumentKey document_key_;
204206
model::BatchId batch_id_;
@@ -238,6 +240,7 @@ class LevelDbMutationQueueKey {
238240
}
239241

240242
private:
243+
// Deliberately uninitialized: will be assigned in Decode
241244
std::string user_id_;
242245
};
243246

@@ -283,7 +286,7 @@ class LevelDbTargetKey {
283286
}
284287

285288
private:
286-
model::TargetId target_id_;
289+
model::TargetId target_id_ = 0;
287290
};
288291

289292
/**
@@ -330,6 +333,7 @@ class LevelDbQueryTargetKey {
330333
}
331334

332335
private:
336+
// Deliberately uninitialized: will be assigned in Decode
333337
std::string canonical_id_;
334338
model::TargetId target_id_;
335339
};
@@ -377,6 +381,7 @@ class LevelDbTargetDocumentKey {
377381
}
378382

379383
private:
384+
// Deliberately uninitialized: will be assigned in Decode
380385
model::TargetId target_id_;
381386
model::DocumentKey document_key_;
382387
};
@@ -424,6 +429,7 @@ class LevelDbDocumentTargetKey {
424429
}
425430

426431
private:
432+
// Deliberately uninitialized: will be assigned in Decode
427433
model::TargetId target_id_;
428434
model::DocumentKey document_key_;
429435
};
@@ -469,6 +475,7 @@ class LevelDbRemoteDocumentKey {
469475
}
470476

471477
private:
478+
// Deliberately uninitialized: will be assigned in Decode
472479
model::DocumentKey document_key_;
473480
};
474481

0 commit comments

Comments
 (0)