Skip to content

Commit 409a3cc

Browse files
authored
Update API documentation referencing removed methods (#6667)
* Update API documentation to remove references to removed methods * Add changelog * Address comments
1 parent 55ab885 commit 409a3cc

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

FirebaseRemoteConfig/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- [removed] Removed deprecated APIs `isDeveloperModeEnabled`, `initWithDeveloperModeEnabled:developerModeEnabled`, `activateWithCompletionHandler:completionHandler`, `activateFetched`, `configValueForKey:namespace`, `configValueForKey:namespace:source`, `allKeysFromSource:namespace`, `keysWithPrefix:namespace`, `setDefaults:namespace`, `setDefaultsFromPlistFileName:namespace`, `defaultValueForKey:namespace`. (#6637)
66
- [fixed] Completion handler for `fetchAndActivateWithCompletionHandler` is now run on the main thread. (#5897)
77
- [fixed] Fixed database creation on tvOS. (#6612)
8+
- [changed] Updated public API documentation to no longer reference removed APIs. (#6641)
89

910
# v4.9.1
1011
- [fixed] Fix an `attempt to insert nil object` crash in `fetchWithExpirationDuration:`. (#6522)

FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -154,20 +154,21 @@ NS_SWIFT_NAME(RemoteConfig)
154154
/// Returns the FIRRemoteConfig instance configured for the default Firebase app. This singleton
155155
/// object contains the complete set of Remote Config parameter values available to the app,
156156
/// including the Active Config and Default Config. This object also caches values fetched from the
157-
/// Remote Config Server until they are copied to the Active Config by calling activateFetched. When
158-
/// you fetch values from the Remote Config Server using the default Firebase namespace service, you
159-
/// should use this class method to create a shared instance of the FIRRemoteConfig object to ensure
160-
/// that your app will function properly with the Remote Config Server and the Firebase service.
157+
/// Remote Config Server until they are copied to the Active Config by calling
158+
/// `activateWithCompletion:`. When you fetch values from the Remote Config Server using the default
159+
/// Firebase namespace service, you should use this class method to create a shared instance of the
160+
/// FIRRemoteConfig object to ensure that your app will function properly with the Remote Config
161+
/// Server and the Firebase service.
161162
+ (nonnull FIRRemoteConfig *)remoteConfig NS_SWIFT_NAME(remoteConfig());
162163

163164
/// Returns the FIRRemoteConfig instance for your (non-default) Firebase appID. Note that Firebase
164165
/// analytics does not work for non-default app instances. This singleton object contains the
165166
/// complete set of Remote Config parameter values available to the app, including the Active Config
166167
/// and Default Config. This object also caches values fetched from the Remote Config Server until
167-
/// they are copied to the Active Config by calling activateFetched. When you fetch values from the
168-
/// Remote Config Server using the default Firebase namespace service, you should use this class
169-
/// method to create a shared instance of the FIRRemoteConfig object to ensure that your app will
170-
/// function properly with the Remote Config Server and the Firebase service.
168+
/// they are copied to the Active Config by calling `activateWithCompletion:`. When you fetch values
169+
/// from the Remote Config Server using the default Firebase namespace service, you should use this
170+
/// class method to create a shared instance of the FIRRemoteConfig object to ensure that your app
171+
/// will function properly with the Remote Config Server and the Firebase service.
171172
+ (nonnull FIRRemoteConfig *)remoteConfigWithApp:(nonnull FIRApp *)app
172173
NS_SWIFT_NAME(remoteConfig(app:));
173174

@@ -179,8 +180,8 @@ NS_SWIFT_NAME(RemoteConfig)
179180
- (void)ensureInitializedWithCompletionHandler:
180181
(void (^_Nonnull)(NSError *_Nullable initializationError))completionHandler;
181182
#pragma mark - Fetch
182-
/// Fetches Remote Config data with a callback. Call activateFetched to make fetched data available
183-
/// to your app.
183+
/// Fetches Remote Config data with a callback. Call `activateWithCompletion:` to make fetched data
184+
/// available to your app.
184185
///
185186
/// Note: This method uses a Firebase Installations token to identify the app instance, and once
186187
/// it's called, it periodically sends data to the Firebase backend. (see
@@ -193,7 +194,7 @@ NS_SWIFT_NAME(RemoteConfig)
193194
NSError *_Nullable error))completionHandler;
194195

195196
/// Fetches Remote Config data and sets a duration that specifies how long config data lasts.
196-
/// Call activateFetched to make fetched data available to your app.
197+
/// Call `activateWithCompletion:` to make fetched data available to your app.
197198
///
198199
/// Note: This method uses a Firebase Installations token to identify the app instance, and once
199200
/// it's called, it periodically sends data to the Firebase backend. (see
@@ -246,16 +247,16 @@ NS_SWIFT_NAME(RemoteConfig)
246247
/// @param key Config key.
247248
- (nonnull FIRRemoteConfigValue *)configValueForKey:(nullable NSString *)key;
248249

249-
/// Gets the config value of a given namespace and a given source.
250+
/// Gets the config value of a given source from the default namespace.
250251
/// @param key Config key.
251252
/// @param source Config value source.
252253
- (nonnull FIRRemoteConfigValue *)configValueForKey:(nullable NSString *)key
253254
source:(FIRRemoteConfigSource)source;
254255

255-
/// Gets all the parameter keys from a given source and a given namespace.
256+
/// Gets all the parameter keys of a given source from the default namespace.
256257
///
257258
/// @param source The config data source.
258-
/// @return An array of keys under the given source and namespace.
259+
/// @return An array of keys under the given source.
259260
- (nonnull NSArray<NSString *> *)allKeysFromSource:(FIRRemoteConfigSource)source;
260261

261262
/// Returns the set of parameter keys that start with the given prefix, from the default namespace
@@ -271,18 +272,19 @@ NS_SWIFT_NAME(RemoteConfig)
271272
/// @param defaults A dictionary mapping a NSString * key to a NSObject * value.
272273
- (void)setDefaults:(nullable NSDictionary<NSString *, NSObject *> *)defaults;
273274

274-
/// Sets default configs from plist for default namespace;
275+
/// Sets default configs from plist for default namespace.
276+
///
275277
/// @param fileName The plist file name, with no file name extension. For example, if the plist file
276278
/// is defaultSamples.plist, call:
277279
/// [[FIRRemoteConfig remoteConfig] setDefaultsFromPlistFileName:@"defaultSamples"];
278280
- (void)setDefaultsFromPlistFileName:(nullable NSString *)fileName
279281
NS_SWIFT_NAME(setDefaults(fromPlist:));
280282

281-
/// Returns the default value of a given key and a given namespace from the default config.
283+
/// Returns the default value of a given key from the default config.
282284
///
283285
/// @param key The parameter key of default config.
284-
/// @return Returns the default value of the specified key and namespace. Returns
285-
/// nil if the key or namespace doesn't exist in the default config.
286+
/// @return Returns the default value of the specified key. Returns
287+
/// nil if the key doesn't exist in the default config.
286288
- (nullable FIRRemoteConfigValue *)defaultValueForKey:(nullable NSString *)key;
287289

288290
@end

FirebaseRemoteConfig/Sources/RCNConfigExperiment.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@
3232
/// Update/Persist experiment information from config fetch response.
3333
- (void)updateExperimentsWithResponse:(NSArray<NSDictionary<NSString *, id> *> *)response;
3434

35-
/// Update experiments to Firebase Analytics when activateFetched happens.
35+
/// Update experiments to Firebase Analytics when `activateWithCompletion:` happens.
3636
- (void)updateExperiments;
3737
@end

0 commit comments

Comments
 (0)