Skip to content

Commit 47c2b31

Browse files
committed
leveldb_snappy_test.cc: fail fast if creating the LevelDb directory fails
1 parent 0ed921a commit 47c2b31

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

Firestore/core/test/unit/local/leveldb_snappy_test.cc

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ void IterateOverLevelDbDatabaseThatUsesSnappyCompression(
8787
std::unique_ptr<leveldb::DB> db;
8888
{
8989
Path leveldb_path = CreateLevelDbDatabaseThatUsesSnappyCompression();
90+
if (leveldb_path.empty()) {
91+
return;
92+
}
9093

9194
leveldb::Options options;
9295
options.create_if_missing = false;
@@ -265,12 +268,18 @@ Path LevelDbDir() {
265268
auto status = fs->RecursivelyRemove(dir);
266269
EXPECT_TRUE(status.ok()) << "Failed to clean up leveldb in directory "
267270
<< dir.ToUtf8String() << ": " << status.ToString();
271+
if (! status.ok()) {
272+
return {};
273+
}
268274

269275
return dir;
270276
}
271277

272278
Path CreateLevelDbDatabaseThatUsesSnappyCompression() {
273279
Path leveldb_dir = LevelDbDir();
280+
if (leveldb_dir.empty()){
281+
return {};
282+
}
274283

275284
WriteFile(leveldb_dir, "000005.ldb", LevelDbSnappyFile_000005_ldb);
276285
WriteFile(leveldb_dir, "000017.ldb", LevelDbSnappyFile_000017_ldb);
@@ -279,6 +288,7 @@ Path CreateLevelDbDatabaseThatUsesSnappyCompression() {
279288
WriteFile(leveldb_dir, "LOG.old", LevelDbSnappyFile_LOG_old);
280289
WriteFile(leveldb_dir, "LOG", LevelDbSnappyFile_LOG);
281290
WriteFile(leveldb_dir, "MANIFEST-000084", LevelDbSnappyFile_MANIFEST_000084);
291+
282292
return leveldb_dir;
283293
}
284294

0 commit comments

Comments
 (0)