Skip to content

Commit 6160676

Browse files
authored
Crashlytics update run script to quote all arguments passed (#6789)
1 parent 88a3f2e commit 6160676

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

Crashlytics/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Unreleased
2+
- [fixed] Fixed an issue where symbol uploads would fail when there are spaces in the project path, particularly in Unity builds (#6789).
3+
14
# v4.6.2
25

36
- [changed] Improved upload-symbols conversion speed. Customers with large dSYMs should see a significant improvement in the time it takes to upload Crashlytics symbols.

Crashlytics/run

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,13 @@
3939
# Figure out where we're being called from
4040
DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
4141

42-
# If the first argument is specified without a dash, treat it as the Fabric API
43-
# Key and add it as an argument.
44-
if [ -z "$1" ] || [[ $1 == -* ]]; then
45-
API_KEY_ARG=""
46-
else
47-
API_KEY_ARG="-a $1"; shift
48-
fi
42+
# Build up the arguments list, passing through any flags added, and quoting
43+
# every argument in case there are spaces in any of the the paths.
44+
ARGUMENTS=''
45+
for i in "$@"; do
46+
ARGUMENTS="$ARGUMENTS \"$i\""
47+
done
4948

50-
# Build up the arguments list, passing through any flags added after the
51-
# API Key
52-
ARGUMENTS="$API_KEY_ARG $@"
5349
VALIDATE_ARGUMENTS="$ARGUMENTS --build-phase --validate"
5450
UPLOAD_ARGUMENTS="$ARGUMENTS --build-phase"
5551

0 commit comments

Comments
 (0)