Throw exception when projectID is missing from FIROptions (#7725)

Author: karenyz

FirebaseRemoteConfig/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [changed] Throw exception if projectID is missing from FirebaseOptions. (#7725)
+
 # v7.9.0
 - [added] Enabled community supported watchOS build in Swift Package Manager. (#7696)
 - [fixed] Don't generate missing Analytics warning on Catalyst. (#7693)

FirebaseRemoteConfig/Sources/FIRRemoteConfigComponent.m

@@ -38,6 +38,8 @@ - (FIRRemoteConfig *)remoteConfigForNamespace:(NSString *)remoteConfigNamespace
     errorPropertyName = @"googleAppID";
   } else if (options.GCMSenderID.length == 0) {
     errorPropertyName = @"GCMSenderID";
+  } else if (options.projectID.length == 0) {
+    errorPropertyName = @"projectID";
   }
 
   if (errorPropertyName) {

FirebaseRemoteConfig/Sources/RCNConfigFetch.m

@@ -516,16 +516,8 @@ - (void)fetchWithUserProperties:(NSDictionary *)userProperties
 - (NSString *)constructServerURL {
   NSString *serverURLStr = [[NSString alloc] initWithString:kServerURLDomain];
   serverURLStr = [serverURLStr stringByAppendingString:kServerURLVersion];
-
-  if (_options.projectID) {
-    serverURLStr = [serverURLStr stringByAppendingString:kServerURLProjects];
-    serverURLStr = [serverURLStr stringByAppendingString:_options.projectID];
-  } else {
-    FIRLogError(kFIRLoggerRemoteConfig, @"I-RCN000070",
-                @"Missing `projectID` from `FirebaseOptions`, please ensure the configured "
-                @"`FirebaseApp` is configured with `FirebaseOptions` that contains a `projectID`.");
-  }
-
+  serverURLStr = [serverURLStr stringByAppendingString:kServerURLProjects];
+  serverURLStr = [serverURLStr stringByAppendingString:_options.projectID];
   serverURLStr = [serverURLStr stringByAppendingString:kServerURLNamespaces];
 
   // Get the namespace from the fully qualified namespace string of "namespace:FIRAppName".

FirebaseRemoteConfig/Tests/Unit/FIRRemoteConfigComponentTest.m

@@ -167,6 +167,35 @@ - (void)testThrowsWithNilGCMSenderID {
   XCTAssertThrows([component remoteConfigForNamespace:@"some_namespace"]);
 }
 
+- (void)testThrowsWithEmptyProjectID {
+  FIROptions *options = [self fakeOptions];
+  options.projectID = @"";
+
+  // Create the provider to vend Remote Config instances.
+  NSString *appName = [self generatedTestAppName];
+  FIRApp *app = [[FIRApp alloc] initInstanceWithName:appName options:options];
+  FIRRemoteConfigComponent *component = [[FIRRemoteConfigComponent alloc] initWithApp:app];
+
+  // Creating a Remote Config instance should fail since the projectID is empty.
+  XCTAssertThrows([component remoteConfigForNamespace:@"some_namespace"]);
+}
+
+- (void)testThrowsWithNilProjectID {
+  FIROptions *options = [self fakeOptions];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnonnull"
+  options.projectID = nil;
+#pragma clang diagnostic pop
+
+  // Create the provider to vend Remote Config instances.
+  NSString *appName = [self generatedTestAppName];
+  FIRApp *app = [[FIRApp alloc] initInstanceWithName:appName options:options];
+  FIRRemoteConfigComponent *component = [[FIRRemoteConfigComponent alloc] initWithApp:app];
+
+  // Creating a Remote Config instance should fail since the projectID is empty.
+  XCTAssertThrows([component remoteConfigForNamespace:@"some_namespace"]);
+}
+
 #pragma mark - Helpers
 
 - (FIROptions *)fakeOptions {