Skip to content

Commit 916759e

Browse files
authored
Fix platforms and zip attribute on new pods (#9670)
1 parent 46956d2 commit 916759e

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

AddNewPod.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ For top-level Firebase pods that map to documented products:
7676
[FIRApp.m](FirebaseCore/Sources/FIRApp.m).
7777
* When ready to release with Firebase, add to the
7878
[Firebase manifest](ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift).
79+
* Create an empty JSON file to enable the Carthage build
80+
[here](ReleaseTooling/Sources/CarthageJSON).
7981
* Add a [quickstart](https://github.com/firebase/quickstart-ios).
8082

8183
## Review and Release
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
{
2+
}

ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ public let shared = Manifest(
3333
Pod("FirebaseCore"),
3434
Pod("FirebaseInstallations"),
3535
Pod("GoogleAppMeasurement", isClosedSource: true),
36-
Pod("GoogleAppMeasurementOnDeviceConversion", isClosedSource: true),
36+
Pod("GoogleAppMeasurementOnDeviceConversion", isClosedSource: true, platforms: ["ios"]),
3737
Pod("FirebaseAnalytics", isClosedSource: true),
38-
Pod("FirebaseAnalyticsOnDeviceConversion", isClosedSource: true),
38+
Pod("FirebaseAnalyticsOnDeviceConversion", isClosedSource: true, platforms: ["ios"], zip: true),
3939
Pod("FirebaseAnalyticsSwift", zip: true),
4040
Pod("FirebaseABTesting", zip: true),
4141
Pod("FirebaseAppCheck", zip: true),

0 commit comments

Comments
 (0)