Skip to content

Commit c989a7b

Browse files
committed
Take 2
1 parent 4267fcb commit c989a7b

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

Firestore/Example/Firestore.xcodeproj/project.pbxproj

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,6 @@
206206
B67BF44A216EB43000CA9097 /* create_noop_connectivity_monitor.cc in Sources */ = {isa = PBXBuildFile; fileRef = B67BF448216EB43000CA9097 /* create_noop_connectivity_monitor.cc */; };
207207
B686F2AF2023DDEE0028D6BE /* field_path_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = B686F2AD2023DDB20028D6BE /* field_path_test.cc */; };
208208
B686F2B22025000D0028D6BE /* resource_path_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = B686F2B02024FFD70028D6BE /* resource_path_test.cc */; };
209-
B69CF05C219B9106004C434D /* FSTFirestoreClient+Testing.mm in Sources */ = {isa = PBXBuildFile; fileRef = B69CF058219B9105004C434D /* FSTFirestoreClient+Testing.mm */; };
210-
B69CF05D219B9106004C434D /* FIRFirestore+Testing.mm in Sources */ = {isa = PBXBuildFile; fileRef = B69CF059219B9105004C434D /* FIRFirestore+Testing.mm */; };
211209
B6BBE43121262CF400C6A53E /* grpc_stream_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = B6BBE42F21262CF400C6A53E /* grpc_stream_test.cc */; };
212210
B6D1B68520E2AB1B00B35856 /* exponential_backoff_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = B6D1B68420E2AB1A00B35856 /* exponential_backoff_test.cc */; };
213211
B6D9649121544D4F00EB9CFB /* grpc_connection_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = B6D9649021544D4F00EB9CFB /* grpc_connection_test.cc */; };
@@ -526,10 +524,7 @@
526524
B67BF448216EB43000CA9097 /* create_noop_connectivity_monitor.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = create_noop_connectivity_monitor.cc; sourceTree = "<group>"; };
527525
B686F2AD2023DDB20028D6BE /* field_path_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = field_path_test.cc; sourceTree = "<group>"; };
528526
B686F2B02024FFD70028D6BE /* resource_path_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = resource_path_test.cc; sourceTree = "<group>"; };
529-
B69CF058219B9105004C434D /* FSTFirestoreClient+Testing.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = "FSTFirestoreClient+Testing.mm"; sourceTree = "<group>"; };
530-
B69CF059219B9105004C434D /* FIRFirestore+Testing.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = "FIRFirestore+Testing.mm"; sourceTree = "<group>"; };
531527
B69CF05A219B9105004C434D /* FIRFirestore+Testing.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "FIRFirestore+Testing.h"; sourceTree = "<group>"; };
532-
B69CF05B219B9105004C434D /* FSTFirestoreClient+Testing.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "FSTFirestoreClient+Testing.h"; sourceTree = "<group>"; };
533528
B6BBE42F21262CF400C6A53E /* grpc_stream_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = grpc_stream_test.cc; sourceTree = "<group>"; };
534529
B6D1B68420E2AB1A00B35856 /* exponential_backoff_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = exponential_backoff_test.cc; sourceTree = "<group>"; };
535530
B6D9649021544D4F00EB9CFB /* grpc_connection_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = grpc_connection_test.cc; sourceTree = "<group>"; };
@@ -1166,9 +1161,6 @@
11661161
isa = PBXGroup;
11671162
children = (
11681163
B69CF05A219B9105004C434D /* FIRFirestore+Testing.h */,
1169-
B69CF059219B9105004C434D /* FIRFirestore+Testing.mm */,
1170-
B69CF05B219B9105004C434D /* FSTFirestoreClient+Testing.h */,
1171-
B69CF058219B9105004C434D /* FSTFirestoreClient+Testing.mm */,
11721164
54E9281C1F33950B00C1953E /* FSTEventAccumulator.h */,
11731165
5492E0392021401F00B64F25 /* FSTEventAccumulator.mm */,
11741166
DE51B1881F0D48AC0013853F /* FSTHelpers.h */,
@@ -2033,7 +2025,6 @@
20332025
files = (
20342026
73866AA12082B0A5009BB4FF /* FIRArrayTransformTests.mm in Sources */,
20352027
5492E079202154D600B64F25 /* FIRCursorTests.mm in Sources */,
2036-
B69CF05D219B9106004C434D /* FIRFirestore+Testing.mm in Sources */,
20372028
5492E075202154D600B64F25 /* FIRDatabaseTests.mm in Sources */,
20382029
5492E073202154D600B64F25 /* FIRFieldsTests.mm in Sources */,
20392030
6161B5032047140C00A99DBB /* FIRFirestoreSourceTests.mm in Sources */,
@@ -2049,7 +2040,6 @@
20492040
5491BC731FB44593008B3588 /* FSTIntegrationTestCase.mm in Sources */,
20502041
5492E080202154EC00B64F25 /* FSTSmokeTests.mm in Sources */,
20512042
5492E07F202154EC00B64F25 /* FSTTransactionTests.mm in Sources */,
2052-
B69CF05C219B9106004C434D /* FSTFirestoreClient+Testing.mm in Sources */,
20532043
5492E0442021457E00B64F25 /* XCTestCase+Await.mm in Sources */,
20542044
B67BF44A216EB43000CA9097 /* create_noop_connectivity_monitor.cc in Sources */,
20552045
EBFC611B1BF195D0EC710AF4 /* app_testing.mm in Sources */,

Firestore/Source/API/FIRFirestore.mm

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,10 @@ @implementation FIRFirestore {
8989
FSTFirestoreClient *_client;
9090
}
9191

92+
- (AsyncQueue*)workerQueue {
93+
return [_client workerQueue];
94+
}
95+
9296
+ (NSMutableDictionary<NSString *, FIRFirestore *> *)instances {
9397
static dispatch_once_t token = 0;
9498
static NSMutableDictionary<NSString *, FIRFirestore *> *instances;

Firestore/Source/Core/FSTFirestoreClient.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,9 @@ NS_ASSUME_NONNULL_BEGIN
117117
*/
118118
- (firebase::firestore::util::Executor *)userExecutor;
119119

120+
/** For testing only. */
121+
- (firebase::firestore::util::AsyncQueue *)workerQueue;
122+
120123
@end
121124

122125
NS_ASSUME_NONNULL_END

Firestore/Source/Core/FSTFirestoreClient.mm

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ - (Executor *)userExecutor {
103103
return _userExecutor.get();
104104
}
105105

106+
- (AsyncQueue*)workerQueue {
107+
return _workerQueue.get();
108+
}
109+
106110
+ (instancetype)clientWithDatabaseInfo:(const DatabaseInfo &)databaseInfo
107111
usePersistence:(BOOL)usePersistence
108112
credentialsProvider:

0 commit comments

Comments
 (0)