Code review changes

Author: eldhosembabu

FIRDynamicLinkTest.m

@@ -50,7 +50,7 @@ - (void)setUp {
 - (void)testDynamicLinkParameters_InitWithParameters {
   FIRDynamicLink *dynamicLink = [[FIRDynamicLink alloc] initWithParametersDictionary:fdlParameters];
   XCTAssertEqual([fdlParameters count], [[dynamicLink parametersDictionary] count]);
-  for (id key in fdlParameters) {
+  for (NSString *key in fdlParameters) {
     NSString *expectedValue = [fdlParameters valueForKey:key];
     NSString *derivedValue = [[dynamicLink parametersDictionary] valueForKey:key];
     XCTAssertNotNil(derivedValue, @"Cannot be null!");
@@ -61,7 +61,7 @@ - (void)testDynamicLinkParameters_InitWithParameters {
 - (void)testDynamicLinkUtmParameters_InitWithParameters {
   FIRDynamicLink *dynamicLink = [[FIRDynamicLink alloc] initWithParametersDictionary:fdlParameters];
   XCTAssertEqual([[dynamicLink utmParametersDictionary] count], [utmParameters count]);
-  for (id key in utmParameters) {
+  for (NSString *key in utmParameters) {
     NSString *expectedValue = [utmParameters valueForKey:key];
     NSString *derivedValue = [[dynamicLink utmParametersDictionary] valueForKey:key];
     XCTAssertNotNil(derivedValue, @"Cannot be null!");

FirebaseDynamicLinks/CHANGELOG.md

@@ -1,5 +1,5 @@
 # v7.7.0
-- [added] Adding "utmParametersDictionary" api to FIRDynamicLink. (#6730)
+- [added] Added `utmParametersDictionary` property to `DynamicLink`. (#6730)
 
 # v7.6.0
 - [fixed] Fixed build warnings introduced with Xcode 12.5. (#7434)

FirebaseDynamicLinks/Sources/FIRDynamicLink.m

@@ -23,7 +23,7 @@
 
 @implementation FIRDynamicLink
 
-NSString *const UTM_PARAM_PREFIX = @"utm_";
+NSString *const FDLUTMParamPrefix = @"utm_";
 
 - (NSString *)description {
   return [NSString stringWithFormat:@"<%@: %p, url [%@], match type: %@, minimumAppVersion: %@, "
@@ -38,7 +38,7 @@ - (instancetype)initWithParametersDictionary:(NSDictionary<NSString *, id> *)par
 
   if (self = [super init]) {
     _parametersDictionary = [parameters copy];
-    _utmParametersDictionary = [[self class] extractUtmParams:parameters];
+    _utmParametersDictionary = [[self class] extractUTMParams:parameters];
     NSString *urlString = parameters[kFIRDLParameterDeepLinkIdentifier];
     _url = [NSURL URLWithString:urlString];
     _inviteId = parameters[kFIRDLParameterInviteId];
@@ -136,18 +136,16 @@ + (FIRDLMatchType)matchTypeWithString:(NSString *)string {
   return [matchMap[string] integerValue] ?: FIRDLMatchTypeNone;
 }
 
-+ (NSDictionary<NSString *, id> *)extractUtmParams:(NSDictionary<NSString *, id> *)parameters {
++ (NSDictionary<NSString *, id> *)extractUTMParams:(NSDictionary<NSString *, id> *)parameters {
   NSMutableDictionary<NSString *, id> *utmParamsDictionary = [[NSMutableDictionary alloc] init];
 
-  if (parameters) {
-    for (id key in parameters) {
-      if ([key hasPrefix:UTM_PARAM_PREFIX]) {
-        [utmParamsDictionary setObject:[parameters valueForKey:key] forKey:key];
-      }
+  for (NSString *key in parameters) {
+    if ([key hasPrefix:FDLUTMParamPrefix]) {
+      [utmParamsDictionary setObject:[parameters valueForKey:key] forKey:key];
     }
   }
 
-  return utmParamsDictionary;
+  return [[NSDictionary alloc] initWithDictionary:utmParamsDictionary];
 }
 
 @end

FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FIRDynamicLink.h

@@ -69,7 +69,7 @@ NS_SWIFT_NAME(DynamicLink)
 
 /**
  * @property utmParametersDictionary
- * @abstract UTM parameters associated with a firebase dynamic link.
+ * @abstract UTM parameters associated with a Firebase Dynamic Link.
  */
 @property(nonatomic, copy, readonly) NSDictionary<NSString *, id> *utmParametersDictionary;