Rename FIRESTORE_TESTS_CMAKE_BUILD to FIREBASE_TESTS_BUILT_BY_CMAKE and move the target_compile_definitions into the firebase_ios_add_test() cmake function

Author: dconeybe

Firestore/core/test/unit/local/CMakeLists.txt

@@ -42,14 +42,6 @@ firebase_ios_glob(
 )
 firebase_ios_add_test(firestore_local_test ${sources})
 
-# Set a preprocessor define so that tests can distinguish between having been
-# built by Xcode vs. cmake.
-target_compile_definitions(
-  firestore_local_test
-  PRIVATE
-  FIRESTORE_TESTS_CMAKE_BUILD
-)
-
 target_link_libraries(
   firestore_local_test PRIVATE
   GMock::GMock

Firestore/core/test/unit/local/leveldb_snappy_test.cc

@@ -49,7 +49,7 @@ Path CreateLevelDbDatabaseThatUsesSnappyCompression();
 void IterateOverLevelDbDatabaseThatUsesSnappyCompression(
     std::function<void(const leveldb::Status&)>);
 
-#if FIRESTORE_TESTS_CMAKE_BUILD
+#if FIREBASE_TESTS_BUILT_BY_CMAKE
 
 // Ensure that LevelDb is compiled with Snappy compression support.
 // See https://github.com/firebase/firebase-ios-sdk/pull/9596 for details.
@@ -60,7 +60,7 @@ TEST(LevelDbSnappy, LevelDbSupportsSnappy) {
       });
 }
 
-#else  // FIRESTORE_TESTS_CMAKE_BUILD
+#else  // FIREBASE_TESTS_BUILT_BY_CMAKE
 
 // Ensure that LevelDb is NOT compiled with Snappy compression support.
 TEST(LevelDbSnappy, LevelDbDoesNotSupportSnappy) {
@@ -81,7 +81,7 @@ TEST(LevelDbSnappy, LevelDbDoesNotSupportSnappy) {
   }
 }
 
-#endif  // FIRESTORE_TESTS_CMAKE_BUILD
+#endif  // FIREBASE_TESTS_BUILT_BY_CMAKE
 
 void IterateOverLevelDbDatabaseThatUsesSnappyCompression(
     std::function<void(const leveldb::Status&)> callback) {

cmake/cc_rules.cmake

@@ -116,6 +116,14 @@ function(firebase_ios_add_test target)
 
   firebase_ios_set_common_target_options(${target} ${flag_OPTIONS})
 
+  # Set a preprocessor define so that tests can distinguish between having been
+  # built by Xcode vs. cmake.
+  target_compile_definitions(
+    ${target}
+    PRIVATE
+    FIREBASE_TESTS_BUILT_BY_CMAKE
+  )
+
   target_link_libraries(${target} PRIVATE GTest::GTest GTest::Main)
 endfunction()