Skip to content

Commit e5cffe2

Browse files
committed
More review feedback
1 parent 4c27c83 commit e5cffe2

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

Firestore/core/src/firebase/firestore/local/leveldb_key.h

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ class LevelDbMutationKey {
131131
}
132132

133133
private:
134+
// Deliberately uninitialized: will be assigned in Decode
134135
std::string user_id_;
135136
model::BatchId batch_id_;
136137
};
@@ -198,6 +199,7 @@ class LevelDbDocumentMutationKey {
198199
}
199200

200201
private:
202+
// Deliberately uninitialized: will be assigned in Decode
201203
std::string user_id_;
202204
model::DocumentKey document_key_;
203205
model::BatchId batch_id_;
@@ -237,6 +239,7 @@ class LevelDbMutationQueueKey {
237239
}
238240

239241
private:
242+
// Deliberately uninitialized: will be assigned in Decode
240243
std::string user_id_;
241244
};
242245

@@ -282,7 +285,7 @@ class LevelDbTargetKey {
282285
}
283286

284287
private:
285-
model::TargetId target_id_;
288+
model::TargetId target_id_ = 0;
286289
};
287290

288291
/**
@@ -329,6 +332,7 @@ class LevelDbQueryTargetKey {
329332
}
330333

331334
private:
335+
// Deliberately uninitialized: will be assigned in Decode
332336
std::string canonical_id_;
333337
model::TargetId target_id_;
334338
};
@@ -376,6 +380,7 @@ class LevelDbTargetDocumentKey {
376380
}
377381

378382
private:
383+
// Deliberately uninitialized: will be assigned in Decode
379384
model::TargetId target_id_;
380385
model::DocumentKey document_key_;
381386
};
@@ -423,6 +428,7 @@ class LevelDbDocumentTargetKey {
423428
}
424429

425430
private:
431+
// Deliberately uninitialized: will be assigned in Decode
426432
model::TargetId target_id_;
427433
model::DocumentKey document_key_;
428434
};
@@ -468,6 +474,7 @@ class LevelDbRemoteDocumentKey {
468474
}
469475

470476
private:
477+
// Deliberately uninitialized: will be assigned in Decode
471478
model::DocumentKey document_key_;
472479
};
473480

0 commit comments

Comments
 (0)